Changeset 102954 in vbox for trunk/src/VBox/HostServices/SharedClipboard/testcase

Timestamp:

Jan 18, 2024 3:32:39 PM (16 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

161182

Message:

Shared Clipboard/Transfer: Made destroying the transfers easier to use by also free'ing the object within ShClTransferDestroy(). Should also fix the memory leaks within the testcase. bugref:9437

File:

• trunk/src/VBox/HostServices/SharedClipboard/testcase/tstClipboardTransfers.cpp (modified) (5 diffs)

trunk/src/VBox/HostServices/SharedClipboard/testcase/tstClipboardTransfers.cpp

@@ -291 +291 @@
     }
 
+    ShClTransferObjOpenParmsDestroy(&openCreateParms);
+
     rc = ShClTransferDestroy(pTransfer);
     RTTESTI_CHECK_RC_OK(rc);
@@ -310 +312 @@
     ShClEventSourceReset(&Source);
     RTTESTI_CHECK(ShClEventSourceGetLast(&Source) == NULL); /* Event still valid, but removed from the source. */
-    RTTESTI_CHECK(ShClEventRelease(pEvent) == 0);
-    RTTESTI_CHECK(ShClEventRelease(pEvent) == UINT32_MAX); /* Ref count already was 0, so returns UINT32_MAX. */
-    RTTESTI_CHECK(ShClEventRelease(pEvent) == UINT32_MAX); /* Again. */
+    RTTESTI_CHECK(ShClEventRelease(pEvent) == 0); /* Free'd event, as ref count is 0. */
     RTTESTI_CHECK(ShClEventSourceGetLast(&Source) == NULL); /* Now it should be empty. */
     RTTESTI_CHECK_RC_OK(ShClEventSourceDestroy(&Source));
@@ -325 +325 @@
     RTTESTI_CHECK(ShClEventRelease(pEvent) == 1);
     RTTESTI_CHECK(ShClEventGetRefs(pEvent) == 1);
-    RTTESTI_CHECK(ShClEventRelease(pEvent) == 0); /* Destroys event, as ref count is 0. */
-    RTTESTI_CHECK(ShClEventRelease(pEvent) == UINT32_MAX);
+    RTTESTI_CHECK(ShClEventRelease(pEvent) == 0); /* Free'd event, as ref count is 0. */
     RTTESTI_CHECK_RC_OK(ShClEventSourceDestroy(&Source)); /* Try to destruct again. */
 }
@@ -339 +338 @@
     rc = ShClTransferDestroy(pTransfer);
     RTTESTI_CHECK_RC_OK(rc);
+    pTransfer = NULL; /* Was free'd above. */
     rc = ShClTransferDestroy(pTransfer); /* Second time, intentional. */
     RTTESTI_CHECK_RC_OK(rc);
@@ -354 +354 @@
     ShClTransferListEntryDestroy(&Entry);
     ShClTransferListEntryDestroy(&Entry); /* Second time, intentional. */
+
+    rc = ShClTransferDestroy(pTransfer);
+    RTTESTI_CHECK_RC_OK(rc);
 }