Changeset 103013 in vbox

Timestamp:

Jan 24, 2024 12:50:12 AM (16 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

161247

Message:

iprt/asm-mem.h,zip.cpp,tstRTInlineAsm.cpp: Eliminated unused ASMMemIsZeroPage function.

Location:

trunk

Files:

• include/iprt/asm-mem.h (modified) (1 diff)
• src/VBox/Runtime/common/zip/zip.cpp (modified) (1 diff)
• src/VBox/Runtime/testcase/tstRTInlineAsm.cpp (modified) (3 diffs)

trunk/include/iprt/asm-mem.h

@@ -298 +298 @@
 
 
-#ifdef RT_ASM_PAGE_SIZE
-/**
- * Checks if a memory page is all zeros.
- *
- * @returns true / false.
- *
- * @param   pvPage      Pointer to the page.  Must be aligned on 16 byte
- *                      boundary
- */
-DECLINLINE(bool) ASMMemIsZeroPage(void const RT_FAR *pvPage) RT_NOTHROW_DEF
-{
-# if 0 /*RT_INLINE_ASM_GNU_STYLE - this is actually slower... */
-    union { RTCCUINTREG r; bool f; } uAX;
-    RTCCUINTREG xCX, xDI;
-   Assert(!((uintptr_t)pvPage & 15));
-    __asm__ __volatile__("repe; "
-#  ifdef RT_ARCH_AMD64
-                         "scasq\n\t"
-#  else
-                         "scasl\n\t"
-#  endif
-                         "setnc %%al\n\t"
-                         : "=&c" (xCX)
-                         , "=&D" (xDI)
-                         , "=&a" (uAX.r)
-                         : "mr" (pvPage)
-#  ifdef RT_ARCH_AMD64
-                         , "0" (RT_ASM_PAGE_SIZE/8)
-#  else
-                         , "0" (RT_ASM_PAGE_SIZE/4)
-#  endif
-                         , "1" (pvPage)
-                         , "2" (0)
-                         : "cc");
-    return uAX.f;
-# else
-   uintptr_t const RT_FAR *puPtr = (uintptr_t const RT_FAR *)pvPage;
-   size_t                  cLeft = RT_ASM_PAGE_SIZE / sizeof(uintptr_t) / 8;
-   Assert(!((uintptr_t)pvPage & 15));
-   for (;;)
-   {
-       if (puPtr[0])        return false;
-       if (puPtr[4])        return false;
-
-       if (puPtr[2])        return false;
-       if (puPtr[6])        return false;
-
-       if (puPtr[1])        return false;
-       if (puPtr[5])        return false;
-
-       if (puPtr[3])        return false;
-       if (puPtr[7])        return false;
-
-       if (!--cLeft)
-           return true;
-       puPtr += 8;
-   }
-# endif
-}
-#endif /* RT_ASM_PAGE_SIZE */
-
-
 /**
  * Checks if a memory block is filled with the specified byte, returning the

trunk/src/VBox/Runtime/common/zip/zip.cpp

@@ -1770 +1770 @@
             if (    cbSrc == _4K
                 &&  !((uintptr_t)pvSrc & 15)
-                &&  ASMMemIsZeroPage(pvSrc))
+                &&  ASMMemIsZero(pvSrc, _4K))
             {
                 if (RT_UNLIKELY(cbDst < sizeof(s_abZero4K)))

trunk/src/VBox/Runtime/testcase/tstRTInlineAsm.cpp

@@ -2398 +2398 @@
             if (pPage->ab[i])
                 RTTestFailed(g_hTest, "ASMMemZeroPage didn't clear byte at offset %#x!\n", i);
-        if (ASMMemIsZeroPage(pPage) != true)
-            RTTestFailed(g_hTest, "ASMMemIsZeroPage returns false after ASMMemZeroPage!\n");
+        if (ASMMemIsZero(pPage, RT_ASM_PAGE_SIZE) != true)
+            RTTestFailed(g_hTest, "ASMMemIsZero/RT_ASM_PAGE_SIZE returns false after ASMMemZeroPage!\n");
         if (ASMMemFirstMismatchingU32(pPage, sizeof(pPage), 0) != NULL)
             RTTestFailed(g_hTest, "ASMMemFirstMismatchingU32(,,0) returns non-NULL after ASMMemZeroPage!\n");
@@ -2410 +2410 @@
     RTTestISub("ASMMemZeroPage");
     DO_SIMPLE_TEST_NO_SUB_NO_STACK(tstASMMemZeroPageWorker, TSTPAGE);
-}
-
-
-static void tstASMMemIsZeroPage(RTTEST hTest)
-{
-    RTTestSub(hTest, "ASMMemIsZeroPage");
-
-    void *pvPage1 = RTTestGuardedAllocHead(hTest, PAGE_SIZE);
-    void *pvPage2 = RTTestGuardedAllocTail(hTest, PAGE_SIZE);
-    RTTESTI_CHECK_RETV(pvPage1 && pvPage2);
-
-    memset(pvPage1, 0, PAGE_SIZE);
-    memset(pvPage2, 0, PAGE_SIZE);
-    RTTESTI_CHECK(ASMMemIsZeroPage(pvPage1));
-    RTTESTI_CHECK(ASMMemIsZeroPage(pvPage2));
-
-    memset(pvPage1, 0xff, PAGE_SIZE);
-    memset(pvPage2, 0xff, PAGE_SIZE);
-    RTTESTI_CHECK(!ASMMemIsZeroPage(pvPage1));
-    RTTESTI_CHECK(!ASMMemIsZeroPage(pvPage2));
-
-    memset(pvPage1, 0, PAGE_SIZE);
-    memset(pvPage2, 0, PAGE_SIZE);
-    for (unsigned off = 0; off < PAGE_SIZE; off++)
-    {
-        ((uint8_t *)pvPage1)[off] = 1;
-        RTTESTI_CHECK(!ASMMemIsZeroPage(pvPage1));
-        ((uint8_t *)pvPage1)[off] = 0;
-
-        ((uint8_t *)pvPage2)[off] = 0x80;
-        RTTESTI_CHECK(!ASMMemIsZeroPage(pvPage2));
-        ((uint8_t *)pvPage2)[off] = 0;
-    }
-
-    RTTestSubDone(hTest);
 }
 
@@ -3333 +3298 @@
 
     tstASMMemZeroPage();
-    tstASMMemIsZeroPage(g_hTest);
     tstASMMemFirstMismatchingU8(g_hTest);
     tstASMMemZero32();