Changeset 103114 in vbox for trunk

Timestamp:

Jan 30, 2024 8:30:58 AM (13 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

161361

Message:

xpcom/xpt_link.c: Fix possible memory leak, bugref:3409

File:

• trunk/src/libs/xpcom18a4/xpcom/typelib/xpt/tools/xpt_link.c (modified) (2 diffs)

trunk/src/libs/xpcom18a4/xpcom/typelib/xpt/tools/xpt_link.c

@@ -212 +212 @@
         }
 
+        whole = XPT_MALLOC(arena, flen);
+        if (!whole) {
+            perror("FAILED: XPT_MALLOC for whole");
+            return 1;
+        }
+
         in = fopen(name, "rb");
         if (!in) {
             perror("FAILED: fopen");
-            return 1;
-        }
-
-        whole = XPT_MALLOC(arena, flen);
-        if (!whole) {
-            perror("FAILED: XPT_MALLOC for whole");
+            XPT_FREE(arena, whole);
             return 1;
         }
@@ -228 +229 @@
             if (rv < flen) {
                 fprintf(stderr, "short read (%zd vs %zd)! ouch!\n", rv, flen);
+                fclose(in);
+                XPT_FREE(arena, whole);
                 return 1;
             }
             if (ferror(in) != 0 || fclose(in) != 0) {
                 perror("FAILED: Unable to read typelib file.\n");
+                XPT_FREE(arena, whole);
                 return 1;
             }