Changeset 103118 in vbox

Timestamp:

Jan 30, 2024 9:01:39 AM (12 months ago)

Author:

vboxsync

Message:

Runtime/r3/http-server.cpp: Fix possible memory leak, small other fixes, bugref:3409

File:

• trunk/src/VBox/Runtime/r3/http-server.cpp (modified) (4 diffs)

trunk/src/VBox/Runtime/r3/http-server.cpp

@@ -745 +745 @@
         RTHTTPHEADERLIST HdrLst;
         rc = RTHttpHeaderListInit(&HdrLst);
-        AssertRCReturn(rc, rc);
+        AssertRCBreak(rc);
 
         char szVal[16];
@@ -753 +753 @@
 
         ssize_t cch = RTStrPrintf2(szVal, sizeof(szVal), "%RU64", fsObj.cbObject);
-        AssertBreakStmt(cch, VERR_BUFFER_OVERFLOW);
+        AssertBreakStmt(cch, rc = VERR_BUFFER_OVERFLOW);
         rc = RTHttpHeaderListAdd(HdrLst, "Content-Length", szVal, strlen(szVal), RTHTTPHEADERLISTADD_F_BACK);
         AssertRCBreak(rc);
 
         cch = RTStrPrintf2(szVal, sizeof(szVal), "identity");
-        AssertBreakStmt(cch, VERR_BUFFER_OVERFLOW);
+        AssertBreakStmt(cch, rc = VERR_BUFFER_OVERFLOW);
         rc = RTHttpHeaderListAdd(HdrLst, "Content-Encoding", szVal, strlen(szVal), RTHTTPHEADERLISTADD_F_BACK);
         AssertRCBreak(rc);
@@ -784 +784 @@
 #endif
             cch = RTStrPrintf2(szVal, sizeof(szVal), "timeout=%RU64", pClient->State.msKeepAlive / RT_MS_1SEC); /** @todo No pipelining support here yet. */
-            AssertBreakStmt(cch, VERR_BUFFER_OVERFLOW);
+            AssertBreakStmt(cch, rc = VERR_BUFFER_OVERFLOW);
             rc = RTHttpHeaderListAdd(HdrLst, "Keep-Alive", szVal, strlen(szVal), RTHTTPHEADERLISTADD_F_BACK);
-            AssertRCReturn(rc, rc);
+            AssertRCBreak(rc);
         }
 
@@ -796 +796 @@
         if (rc == VERR_BROKEN_PIPE) /* Could happen on fast reloads. */
             break;
-        AssertRCReturn(rc, rc);
+        AssertRCBreak(rc);
 
         size_t cbToRead  = fsObj.cbObject;