Changeset 103130 in vbox

Timestamp:

Jan 31, 2024 8:37:41 AM (12 months ago)

Author:

vboxsync

Message:

xpcom/xpidl_idl.c: Fix possible (harmless) memory leaks, bugref:3409

File:

• trunk/src/libs/xpcom18a4/xpcom/typelib/xpidl/xpidl_idl.c (modified) (5 diffs)

trunk/src/libs/xpcom18a4/xpcom/typelib/xpidl/xpidl_idl.c

@@ -216 +216 @@
         just_read = fread(buffer + offset, 1, buffer_size - offset, inputfile);
         if (ferror(inputfile))
+        {
+            free(buffer);
             return NULL;
+        }
 
         if (just_read < buffer_size - offset || just_read == 0) {
@@ -473 +476 @@
 }
 
+#ifndef VBOX
 /* set this with a debugger to see exactly what libIDL sees */
 static FILE *tracefile = NULL;
+#endif
 
 static int
@@ -611 +616 @@
         data->point = start + copy;
 
+#ifndef VBOX
         if (tracefile)
             fwrite(cb_data->fill.buffer, copy, 1, tracefile);
+#endif
 
         return copy;
@@ -717 +724 @@
             g_warning("Parse of %s failed", filename);
         }
+        free(outname);
         return 0;
     }
@@ -762 +770 @@
         if (!state.file) {
             perror("error opening output file");
+            free(outname);
             return 0;
         }