Changeset 103180 in vbox

Timestamp:

Feb 2, 2024 5:26:54 PM (14 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

161443

Message:

FE/Qt: bugref:10384: VM settings / System page: Hiding chipset type editor for ARM host.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.cpp (modified) (7 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.cpp

@@ -237 +237 @@
 KChipsetType UIMachineSettingsSystem::chipsetType() const
 {
-    return m_pEditorChipset->value();
+    return   m_pEditorChipset
+           ? m_pEditorChipset->value()
+           : m_pCache->base().m_chipsetType;
 }
 
@@ -405 +407 @@
     if (m_pEditorBootOrder)
         newSystemData.m_bootItems = m_pEditorBootOrder->value();
-    if (m_pEditorChipset)
-        newSystemData.m_chipsetType = m_pEditorChipset->value();
+    newSystemData.m_chipsetType = chipsetType();
     if (m_pEditorTpm)
         newSystemData.m_tpmType = m_pEditorTpm->value();
@@ -412 +413 @@
         newSystemData.m_pointingHIDType = m_pEditorPointingHID->value();
     if (   m_pEditorMotherboardFeatures
-        && m_pEditorVCPU
-        && m_pEditorChipset)
+        && m_pEditorVCPU)
         newSystemData.m_fEnabledIoApic =    m_pEditorMotherboardFeatures->isEnabledIoApic()
                                          || m_pEditorVCPU->value() > 1
-                                         || m_pEditorChipset->value() == KChipsetType_ICH9;
+                                         || chipsetType() == KChipsetType_ICH9;
     if (m_pEditorMotherboardFeatures)
         newSystemData.m_fEnabledEFI = m_pEditorMotherboardFeatures->isEnabledEfi();
@@ -494 +494 @@
 
         /* Chipset type vs IO-APIC test: */
-        if (m_pEditorChipset->value() == KChipsetType_ICH9 && !m_pEditorMotherboardFeatures->isEnabledIoApic())
+        if (   chipsetType() == KChipsetType_ICH9
+            && !m_pEditorMotherboardFeatures->isEnabledIoApic())
         {
             message.second << tr(
@@ -634 +635 @@
     m_pEditorBaseMemory->setEnabled(isMachineOffline());
     m_pEditorBootOrder->setEnabled(isMachineOffline());
-    m_pEditorChipset->setEnabled(isMachineOffline());
+    if (m_pEditorChipset)
+        m_pEditorChipset->setEnabled(isMachineOffline());
     m_pEditorTpm->setEnabled(isMachineOffline());
     m_pEditorPointingHID->setEnabled(isMachineOffline());
@@ -727 +729 @@
 
             /* Prepare chipset editor: */
+#ifndef VBOX_WITH_VIRT_ARMV8
             m_pEditorChipset = new UIChipsetEditor(m_pTabMotherboard);
+#endif
             if (m_pEditorChipset)
             {
@@ -859 +863 @@
 {
     /* Configure 'Motherboard' connections: */
-    connect(m_pEditorChipset, &UIChipsetEditor::sigValueChanged,
-            this, &UIMachineSettingsSystem::revalidate);
+    if (m_pEditorChipset)
+        connect(m_pEditorChipset, &UIChipsetEditor::sigValueChanged,
+                this, &UIMachineSettingsSystem::revalidate);
     connect(m_pEditorTpm, &UITpmEditor::sigValueChanged,
             this, &UIMachineSettingsSystem::revalidate);