Changeset 103184 in vbox for trunk/src

Timestamp:

Feb 3, 2024 8:16:32 PM (16 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

161449

Message:

Fix broken build and broken 'with assembly' ability to run VMs at all; from r161447:

VMM/IEM: IEMIMPL_SHIFT_OPT_F3 macro to emit vpsll-family instruction blocks
VMM/IEM: add missing 'non-fallback' iemAImpl_vpsll[wdq]_imm_u{128,256} functions

bugref:9898

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• IEMAllAImpl.asm (modified) (1 diff)
• IEMAllAImplC.cpp (modified) (6 diffs)
• IEMAllInstVexMap1.cpp.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllAImpl.asm

@@ -4426 +4426 @@
 IEMIMPL_MEDIA_OPT_F3 vpaddsb
 IEMIMPL_MEDIA_OPT_F3 vpaddsw
-IEMIMPL_MEDIA_OPT_F3 vpsllw
-IEMIMPL_MEDIA_OPT_F3 vpslld
-IEMIMPL_MEDIA_OPT_F3 vpsllq
+
+;;
+; Media instruction working on one full sized source register, one full sized destination
+; register, and one no-larger-than-XMM register (in the vps{ll,ra,rl}[dwq] instructions,
+; this is actually used to retrieve a 128-bit load, from which a 64-bit shift length is
+; extracted; if the 64-bit unsigned value is larger than the permissible max shift size
+; of either 16, 32, or 64, it acts like the max shift size)
+;
+; @param    1       The instruction
+;
+; @param    A0      Pointer to the destination media register size operand (output).
+; @param    A1      Pointer to the first source media register size operand (input).
+; @param    A2      Pointer to the second source media register size operand (input).
+;
+%macro IEMIMPL_SHIFT_OPT_F3 1
+BEGINPROC_FASTCALL iemAImpl_ %+ %1 %+ _u128, 12
+        PROLOGUE_3_ARGS
+        IEMIMPL_AVX_PROLOGUE
+
+        vmovdqu  xmm0, [A1]
+        vmovdqu  xmm1, [A2]
+        %1       xmm0, xmm0, xmm1
+        vmovdqu  [A0], xmm0
+
+        IEMIMPL_AVX_PROLOGUE
+        EPILOGUE_3_ARGS
+ENDPROC iemAImpl_ %+ %1 %+ _u128
+
+BEGINPROC_FASTCALL iemAImpl_ %+ %1 %+ _u256, 12
+        PROLOGUE_3_ARGS
+        IEMIMPL_AVX_PROLOGUE
+
+        vmovdqu  ymm0, [A1]
+        vmovdqu  xmm1, [A2]
+        %1       ymm0, ymm0, xmm1
+        vmovdqu  [A0], ymm0
+
+        IEMIMPL_AVX_PROLOGUE
+        EPILOGUE_3_ARGS
+ENDPROC iemAImpl_ %+ %1 %+ _u256
+%endmacro
+
+IEMIMPL_SHIFT_OPT_F3 vpsllw
+IEMIMPL_SHIFT_OPT_F3 vpslld
+IEMIMPL_SHIFT_OPT_F3 vpsllq
 
 

trunk/src/VBox/VMM/VMMAll/IEMAllAImplC.cpp

@@ -10343 +10343 @@
 }
 
+IEM_DECL_IMPL_DEF(void, iemAImpl_vpsllw_imm_u128,(PRTUINT128U puDst, PCRTUINT128U puSrc1, uint8_t uShift))
+{
+    iemAImpl_vpsllw_imm_u128_fallback(puDst, puSrc1, uShift);
+}
+
 IEM_DECL_IMPL_DEF(void, iemAImpl_vpsllw_imm_u256_fallback,(PRTUINT256U puDst, PCRTUINT256U puSrc1, uint8_t uShift))
 {
@@ -10380 +10385 @@
 }
 
+IEM_DECL_IMPL_DEF(void, iemAImpl_vpsllw_imm_u256,(PRTUINT256U puDst, PCRTUINT256U puSrc1, uint8_t uShift))
+{
+    iemAImpl_vpsllw_imm_u256_fallback(puDst, puSrc1, uShift);
+}
+
 /*
  * PSRLD / VPSRLD
@@ -10638 +10648 @@
         puDst->au64[1] = 0;
     }
+}
+
+IEM_DECL_IMPL_DEF(void, iemAImpl_vpslld_imm_u128,(PRTUINT128U puDst, PCRTUINT128U puSrc1, uint8_t uShift))
+{
+    iemAImpl_vpslld_imm_u128_fallback(puDst, puSrc1, uShift);
 }
 
@@ -10674 +10689 @@
 }
 
+IEM_DECL_IMPL_DEF(void, iemAImpl_vpslld_imm_u256,(PRTUINT256U puDst, PCRTUINT256U puSrc1, uint8_t uShift))
+{
+    iemAImpl_vpslld_imm_u256_fallback(puDst, puSrc1, uShift);
+}
+
 
 /*
@@ -10843 +10863 @@
 {
     iemAImpl_vpsllq_imm_u128_fallback(puDst, puSrc1, puSrc2->au8[0]);
+}
+
+IEM_DECL_IMPL_DEF(void, iemAImpl_vpsllq_imm_u128,(PRTUINT128U puDst, PCRTUINT128U puSrc1, uint8_t uShift))
+{
+    iemAImpl_vpsllq_imm_u128_fallback(puDst, puSrc1, uShift);
 }
 
@@ -10868 +10893 @@
 {
     iemAImpl_vpsllq_imm_u256_fallback(puDst, puSrc1, puSrc2->au8[0]);
+}
+
+IEM_DECL_IMPL_DEF(void, iemAImpl_vpsllq_imm_u256,(PRTUINT256U puDst, PCRTUINT256U puSrc1, uint8_t uShift))
+{
+    iemAImpl_vpsllq_imm_u256_fallback(puDst, puSrc1, uShift);
 }
 

trunk/src/VBox/VMM/VMMAll/IEMAllInstVexMap1.cpp.h

@@ -3684 +3684 @@
 FNIEMOP_DEF_1(iemOp_VGrp13_vpslld_Hx_Ux_Ib, uint8_t, bRm)
 {
-(void)bRm;
     IEMOP_MNEMONIC3(VEX_VMI_REG, VPSLLD, vpslld, Hx, Ux, Ib, DISOPTYPE_HARMLESS | DISOPTYPE_X86_AVX, 0);
     if (pVCpu->iem.s.uVexLength)