Changeset 103214 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Feb 6, 2024 2:03:41 AM (13 months ago)

Author:

vboxsync

Message:

VMM/IEMAllInst*: Liveness analysis, part 7: Flag input & modification annotations checks. bugref:10372

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• IEMAllInstPython.py (modified) (6 diffs)
• IEMAllThrdPython.py (modified) (7 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllInstPython.py

@@ -2012 +2012 @@
     ## @}
 
-    def __init__(self, sSrcFile, iBeginLine, offBeginLine, oFunction, iInFunction, cchIndent = None, fDeferToCImpl = False):
+    def __init__(self, sSrcFile, iBeginLine, offBeginLine, oFunction, iInFunction,
+                 oInstruction = None, cchIndent = None, fDeferToCImpl = False):
         ## Set if IEM_MC_DEFER_TO_CIMPL_0_RET and friends, clear if IEM_MC_BEGIN/END block.
         self.fDeferToCImpl = fDeferToCImpl;
@@ -2033 +2034 @@
         ## The block number within the function.
         self.iInFunction  = iInFunction;
+        ## The instruction this block is associated with - can be None.
+        self.oInstruction = oInstruction;
+        ## Indentation level of the block.
         self.cchIndent    = cchIndent if cchIndent else offBeginLine;
-        ##< The raw lines the block is made up of.
+        ## The raw lines the block is made up of.
         self.asLines      = []              # type: List[str]
         ## Indicates whether the block includes macro expansion parts (kiMacroExp_None,
@@ -4432 +4436 @@
         return True;
 
-
     def parseTagOpHints(self, sTag, aasSections, iTagLine, iEndLine):
         """
@@ -5305 +5308 @@
         # Start a new block.
         # But don't add it to the list unless the context matches the host architecture.
-        self.oCurMcBlock = McBlock(self.sSrcFile, self.iLine, offBeginStatementInLine,
-                                   self.oCurFunction, self.iMcBlockInFunc, cchIndent);
+        self.oCurMcBlock = McBlock(self.sSrcFile, self.iLine, offBeginStatementInLine, self.oCurFunction, self.iMcBlockInFunc,
+                                   oInstruction = self.aoCurInstrs[-1] if self.aoCurInstrs else None,
+                                   cchIndent = cchIndent);
         try:
             if (   not self.aoCppCondStack
@@ -5442 +5446 @@
 
         # Start a new block.
-        oMcBlock = McBlock(self.sSrcFile, self.iLine, offBeginStatementInLine,
-                           self.oCurFunction, self.iMcBlockInFunc, cchIndent, fDeferToCImpl = True);
+        oMcBlock = McBlock(self.sSrcFile, self.iLine, offBeginStatementInLine, self.oCurFunction, self.iMcBlockInFunc,
+                           oInstruction = self.aoCurInstrs[-1] if self.aoCurInstrs else None,
+                           cchIndent = cchIndent, fDeferToCImpl = True);
 
         # Parse the statment.
@@ -6010 +6015 @@
                       self.cTotalMcBlocks, os.path.basename(self.sSrcFile),));
         return self.printErrors();
+
+# Some sanity checking.
+for sClass, dLists in SimpleParser.kdEFlagsClasses.items():
+    for sAttrib, asFlags in dLists.items():
+        for sFlag in asFlags:
+            assert sFlag in g_kdEFlagsMnemonics, 'sClass=%s sAttrib=%s sFlag=%s' % (sClass, sAttrib, sFlag,);
 
 ## The parsed content of IEMAllInstCommonBodyMacros.h.

trunk/src/VBox/VMM/VMMAll/IEMAllThrdPython.py

@@ -1540 +1540 @@
         raise Exception('%s:%s: error: %s' % (self.oMcBlock.sSrcFile, self.oMcBlock.iBeginLine, sMessage, ));
 
+    def error(self, sMessage, oGenerator):
+        """ Emits an error via the generator object, causing it to fail. """
+        oGenerator.rawError('%s:%s: error: %s' % (self.oMcBlock.sSrcFile, self.oMcBlock.iBeginLine, sMessage, ));
+
     def warning(self, sMessage):
         """ Emits a warning. """
@@ -1562 +1566 @@
         return True;
 
-    def analyzeCodeOperation(self, aoStmts: List[iai.McStmt], fSeenConditional = False) -> bool:
+    def analyzeCodeOperation(self, aoStmts: List[iai.McStmt], dEflStmts, fSeenConditional = False) -> bool:
         """
         Analyzes the code looking clues as to additional side-effects.
@@ -1616 +1620 @@
                 sAnnotation = g_ksFinishAnnotation_DeferToCImpl;
 
+            # Collect MCs working on EFLAGS.  Caller will check this.
+            if oStmt.sName in ('IEM_MC_FETCH_EFLAGS', 'IEM_MC_FETCH_EFLAGS_U8', 'IEM_MC_COMMIT_EFLAGS', 'IEM_MC_REF_EFLAGS',
+                               'IEM_MC_ARG_LOCAL_EFLAGS', ):
+                dEflStmts[oStmt.sName] = oStmt;
+            elif isinstance(oStmt, iai.McStmtCall):
+                if oStmt.sName in ('IEM_MC_CALL_CIMPL_0', 'IEM_MC_CALL_CIMPL_1', 'IEM_MC_CALL_CIMPL_2',
+                                   'IEM_MC_CALL_CIMPL_3', 'IEM_MC_CALL_CIMPL_4', 'IEM_MC_CALL_CIMPL_5',):
+                    if (   oStmt.asParams[0].find('IEM_CIMPL_F_RFLAGS')       >= 0
+                        or oStmt.asParams[0].find('IEM_CIMPL_F_STATUS_FLAGS') >= 0):
+                        dEflStmts[oStmt.sName] = oStmt;
+
             # Process branches of conditionals recursively.
             if isinstance(oStmt, iai.McStmtCond):
-                oStmt.oIfBranchAnnotation = self.analyzeCodeOperation(oStmt.aoIfBranch, True);
+                oStmt.oIfBranchAnnotation = self.analyzeCodeOperation(oStmt.aoIfBranch, dEflStmts, True);
                 if oStmt.aoElseBranch:
-                    oStmt.oElseBranchAnnotation = self.analyzeCodeOperation(oStmt.aoElseBranch, True);
+                    oStmt.oElseBranchAnnotation = self.analyzeCodeOperation(oStmt.aoElseBranch, dEflStmts, True);
 
         return sAnnotation;
 
-    def analyze(self):
+    def analyze(self, oGenerator):
         """
         Analyzes the code, identifying the number of parameters it requires and such.
@@ -1645 +1660 @@
         # Scan the code for IEM_CIMPL_F_ and other clues.
         self.dsCImplFlags = self.oMcBlock.dsCImplFlags.copy();
-        self.analyzeCodeOperation(aoStmts);
+        dEflStmts         = {};
+        self.analyzeCodeOperation(aoStmts, dEflStmts);
         if (   ('IEM_CIMPL_F_CALLS_CIMPL' in self.dsCImplFlags)
              + ('IEM_CIMPL_F_CALLS_AIMPL' in self.dsCImplFlags)
              + ('IEM_CIMPL_F_CALLS_AIMPL_WITH_FXSTATE' in self.dsCImplFlags) > 1):
-            self.raiseProblem('Mixing CIMPL/AIMPL/AIMPL_WITH_FXSTATE calls');
+            self.error('Mixing CIMPL/AIMPL/AIMPL_WITH_FXSTATE calls', oGenerator);
+
+        # Analyse EFLAGS related MCs and @opflmodify and friends.
+        if dEflStmts:
+            oInstruction = self.oMcBlock.oInstruction; # iai.Instruction
+            if (   oInstruction is None
+                or (oInstruction.asFlTest is None and oInstruction.asFlModify is None)):
+                sMcNames = '+'.join(dEflStmts.keys());
+                if len(dEflStmts) != 1 or not sMcNames.startswith('IEM_MC_CALL_CIMPL_'): # Hack for far calls
+                    self.error('Uses %s but has no @opflmodify, @opfltest or @opflclass with details!' % (sMcNames,), oGenerator);
+            elif 'IEM_MC_COMMIT_EFLAGS' in dEflStmts:
+                if not oInstruction.asFlModify:
+                    if oInstruction.sMnemonic not in [ 'not', ]:
+                        self.error('Uses IEM_MC_COMMIT_EFLAGS but has no flags in @opflmodify!', oGenerator);
+            elif (   'IEM_MC_CALL_CIMPL_0' in dEflStmts
+                  or 'IEM_MC_CALL_CIMPL_1' in dEflStmts
+                  or 'IEM_MC_CALL_CIMPL_2' in dEflStmts
+                  or 'IEM_MC_CALL_CIMPL_3' in dEflStmts
+                  or 'IEM_MC_CALL_CIMPL_4' in dEflStmts
+                  or 'IEM_MC_CALL_CIMPL_5' in dEflStmts ):
+                if not oInstruction.asFlModify:
+                    self.error('Uses IEM_MC_CALL_CIMPL_x or IEM_MC_DEFER_TO_CIMPL_5_RET with IEM_CIMPL_F_STATUS_FLAGS '
+                               'or IEM_CIMPL_F_RFLAGS but has no flags in @opflmodify!', oGenerator);
+            elif 'IEM_MC_REF_EFLAGS' not in dEflStmts:
+                if not oInstruction.asFlTest:
+                    if oInstruction.sMnemonic not in [ 'not', ]:
+                        self.error('Expected @opfltest!', oGenerator);
+            if oInstruction and oInstruction.asFlSet:
+                for sFlag in oInstruction.asFlSet:
+                    if sFlag not in oInstruction.asFlModify:
+                        self.error('"%s" in  @opflset but missing from @opflmodify (%s)!'
+                                   % (sFlag, ', '.join(oInstruction.asFlModify)), oGenerator);
+            if oInstruction and oInstruction.asFlClear:
+                for sFlag in oInstruction.asFlClear:
+                    if sFlag not in oInstruction.asFlModify:
+                        self.error('"%s" in  @opflclear but missing from @opflmodify (%s)!'
+                                   % (sFlag, ', '.join(oInstruction.asFlModify)), oGenerator);
 
         # Create variations as needed.
@@ -2130 +2182 @@
         self.aoParsers       = []       # type: List[IEMAllInstPython.SimpleParser]
         self.aidxFirstFunctions = []    # type: List[int] ##< Runs parallel to aoParser giving the index of the first function.
+        self.cErrors         = 0;
+
+    #
+    # Error reporting.
+    #
+
+    def rawError(self, sCompleteMessage):
+        """ Output a raw error and increment the error counter. """
+        print(sCompleteMessage, file = sys.stderr);
+        self.cErrors += 1;
+        return False;
 
     #
@@ -2150 +2213 @@
         dMinParamCounts = {};
         for oThreadedFunction in self.aoThreadedFuncs:
-            oThreadedFunction.analyze();
+            oThreadedFunction.analyze(self);
             for oVariation in oThreadedFunction.aoVariations:
                 dRawParamCounts[len(oVariation.dParamRefs)] = dRawParamCounts.get(len(oVariation.dParamRefs), 0) + 1;
@@ -2211 +2274 @@
               % (cbMaxVarsAndArgs, cMaxVarsAndArgs, cbMaxVars, cMaxVars, cbMaxArgs, cMaxArgs,), file = sys.stderr);
 
+        if self.cErrors > 0:
+            print('fatal error: %u error%s during processing. Details above.'
+                  % (self.cErrors, 's' if self.cErrors > 1 else '',), file = sys.stderr);
+            return False;
         return True;