Changeset 103239 in vbox for trunk/src/VBox/GuestHost

Timestamp:

Feb 7, 2024 11:20:17 AM (10 months ago)

Author:

vboxsync

Message:

Shared Clipboard/tstClipboardGH-X11: Fixed a leak in tstShClOnSendDataToDestCallback().

File:

• trunk/src/VBox/GuestHost/SharedClipboard/testcase/tstClipboardGH-X11.cpp (modified) (5 diffs)

trunk/src/VBox/GuestHost/SharedClipboard/testcase/tstClipboardGH-X11.cpp

@@ -426 +426 @@
     g_tst_cbCompleted = cb;
 
+    if (pData->enmType == SHCLX11EVENTTYPE_READ)
+        RTMemFree(pData->Read.pvData);
+    RTMemFree(pData);
+
     return VINF_SUCCESS;
 }
@@ -468 +472 @@
                              const char *pcszExp, int rcExp)
 {
-    bool retval = true;
+    bool fRc = true;
     tstClipSendTargetUpdate(pCtx);
     if (tstClipQueryFormats() != VBOX_SHCL_FMT_UNICODETEXT)
@@ -482 +486 @@
             RTTestFailed(hTest, "Wrong return code, expected %Rrc, got %Rrc\n", rcExp, rc);
         else if (RT_FAILURE(rcExp))
-            retval = true;
+            fRc = true;
         else
         {
@@ -500 +504 @@
                 {
                     if (memcmp(abBuf, wcExp, cbExp) == 0)
-                        retval = true;
+                        fRc = true;
                     else
                         RTTestFailed(hTest, "Returned string \"%.*ls\" does not match expected string \"%s\"\n",
@@ -508 +512 @@
         }
     }
-    if (!retval)
-        RTTestFailureDetails(hTest, "Expected: string \"%s\", rc %Rrc\n",
-                             pcszExp, rcExp);
+    if (!fRc)
+        RTTestFailureDetails(hTest, "Expected: string \"%s\", rc=%Rrc\n", pcszExp, rcExp);
 }