Changeset 103287 in vbox

Timestamp:

Feb 8, 2024 6:09:31 PM (12 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10384: VM settings / System page: Chipset option should not be hidden just for ARM host, but for ARM VMs instead; Besides that, processor feature options follows the same logic.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine

Files:

• UIMachineSettingsSystem.cpp (modified) (5 diffs)
• UIMachineSettingsSystem.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.cpp

@@ -624 +624 @@
 void UIMachineSettingsSystem::handleFilterChange()
 {
+    /* Update some stuff: */
+    updateOptionSet();
     updateMinimumLayoutHint();
 }
@@ -657 +659 @@
                                                                       || (systemData.m_fEnabledNestedPaging && isMachineOffline()));
     }
+
+    /* Update option set: */
+    updateOptionSet();
 }
 
@@ -668 +673 @@
     prepareWidgets();
     prepareConnections();
+
+    /* Update option set: */
+    updateOptionSet();
 
     /* Apply language settings: */
@@ -729 +737 @@
 
             /* Prepare chipset editor: */
-#ifndef VBOX_WITH_VIRT_ARMV8
             m_pEditorChipset = new UIChipsetEditor(m_pTabMotherboard);
-#endif
             if (m_pEditorChipset)
             {
@@ -887 +893 @@
         connect(m_pEditorAccelerationFeatures, &UIAccelerationFeaturesEditor::sigChangedNestedPaging,
                 this, &UIMachineSettingsSystem::revalidate);
+}
+
+void UIMachineSettingsSystem::updateOptionSet()
+{
+    /* Load currently propagated arch type: */
+    const KPlatformArchitecture enmArch = optionalFlags().contains("arch")
+                                        ? optionalFlags().value("arch").value<KPlatformArchitecture>()
+                                        : KPlatformArchitecture_x86;
+
+    /* Some options visible only for x86 machines: */
+    const bool fx86 = enmArch == KPlatformArchitecture_x86;
+    m_pEditorChipset->setVisible(fx86);
+    m_pEditorProcessorFeatures->setVisible(fx86);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.h

@@ -133 +133 @@
     /** Prepares connections. */
     void prepareConnections();
+    /** Updates option set. */
+    void updateOptionSet();
     /** Cleanups all. */
     void cleanup();