Changeset 103294 in vbox

Timestamp:

Feb 9, 2024 3:20:37 PM (12 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

161588

Message:

FE/Qt: bugref:10513: VM settings / Storage page: Give storage controllers some priorities so that if VM has few of them, Basic experience mode could use the one with higher.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIStorageSettingsEditor.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIStorageSettingsEditor.cpp

@@ -5158 +5158 @@
     if (pModel->rowCount(currentIndex) > 0)
     {
-        /* Why not select it as well?
-         * It contains all the attachments we have (there): */
-        currentIndex = pModel->index(0, 0, currentIndex);
+        /* Let's enumerate controllers according to their bus type priorities: */
+        // For future support we have possibility to show Unknown bus above Low one.
+        enum BusPriority { BusPriority_High, BusPriority_Medium, BusPriority_Unknown, BusPriority_Low };
+        QMap<BusPriority, int> busPositions;
+        for (int i = 0; i < pModel->rowCount(currentIndex); ++i)
+        {
+            /* Acquire iterated controller bus type: */
+            const QModelIndex controllerIndex = pModel->index(i, 0, currentIndex);
+            const KStorageBus enmBus = pModel->data(controllerIndex, StorageModel::R_CtrBusType).value<KStorageBus>();
+            BusPriority enmBusPriority = BusPriority_Unknown;
+            switch (enmBus)
+            {
+                case KStorageBus_SATA:
+                    enmBusPriority = BusPriority_High;
+                    break;
+                case KStorageBus_IDE:
+                case KStorageBus_SCSI:
+                case KStorageBus_SAS:
+                case KStorageBus_VirtioSCSI:
+                    enmBusPriority = BusPriority_Medium;
+                    break;
+                case KStorageBus_Floppy:
+                case KStorageBus_USB:
+                case KStorageBus_PCIe:
+                    enmBusPriority = BusPriority_Low;
+                    break;
+                default:
+                    break;
+            }
+            if (!busPositions.contains(enmBusPriority))
+                busPositions[enmBusPriority] = i;
+        }
+        if (!busPositions.isEmpty())
+        {
+            /* Why not select it as well?
+             * It contains all the attachments we have (there): */
+            currentIndex = pModel->index(busPositions.first(), 0, currentIndex);
+        }
         /* For Basic experience mode: */
         if (!m_fInExpertMode)