Changeset 103311 in vbox for trunk/src/VBox/Main/src-all

Timestamp:

Feb 12, 2024 12:33:46 PM (14 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

161607

Message:

Fixed some (potential) va_args leaks (found by Parfait). ​bugref:3409

File:

• trunk/src/VBox/Main/src-all/ExtPackManagerImpl.cpp (modified) (4 diffs)

trunk/src/VBox/Main/src-all/ExtPackManagerImpl.cpp

@@ -2703 +2703 @@
     apszArgs[cArgs++] = a_pszCommand;
 
+    HRESULT hrc = S_OK;
+
     va_list va;
     va_start(va, a_pszCommand);
@@ -2708 +2710 @@
     for (;;)
     {
-        AssertReturn(cArgs < RT_ELEMENTS(apszArgs) - 1, E_UNEXPECTED);
+        AssertBreakStmt(cArgs < RT_ELEMENTS(apszArgs) - 1, hrc = E_UNEXPECTED);
         pszLastArg = va_arg(va, const char *);
         if (!pszLastArg)
@@ -2716 +2718 @@
     };
     va_end(va);
+    ComAssertComRCRet(hrc, hrc);
 
     LogRel(("\n"));
@@ -2733 +2736 @@
      * Spawn the process.
      */
-    HRESULT hrc;
     RTPROCESS hProcess;
     vrc = RTProcCreateEx(szExecName,