Changeset 103328 in vbox for trunk/src/VBox/Installer/win/InstallHelper

Timestamp:

Feb 13, 2024 1:07:31 AM (14 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

161631

Message:

Installer/VBoxInstallHelper.cpp: Degraded todo severity and explained why it probably works with the wrong value. bugref:10579

File:

• trunk/src/VBox/Installer/win/InstallHelper/VBoxInstallHelper.cpp (modified) (1 diff)

trunk/src/VBox/Installer/win/InstallHelper/VBoxInstallHelper.cpp

@@ -616 +616 @@
         {
             /* Set required environment variables. */
-            if (SetEnvironmentVariableW(L"VBOX_INSTALL_PATH", wszVBoxPythonInstallerPath)) /** @todo BUGBUG r=andy That can't be right! */
+            /** @todo r=andy: That can't be right!
+             *
+             *  r=bird: The variable probably isn't used because VBOX_MSI_INSTALL_PATH is
+             *          set by VBoxMergeApp.wxi. */
+            if (SetEnvironmentVariableW(L"VBOX_INSTALL_PATH", wszVBoxPythonInstallerPath))
             {
                 logStringF(hModule, "InstallPythonAPI: Invoking vboxapisetup.py in \"%ls\" ...", wszVBoxPythonInstallerPath);