Changeset 103346 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Feb 14, 2024 2:06:13 AM (12 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

161659

Message:

DrvCloudTunnel: Switch the RTStrPrintfV calls with RTStrPrintf2V which has easier overflow handling. bugref:10539

File:

• trunk/src/VBox/Devices/Network/DrvCloudTunnel.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Network/DrvCloudTunnel.cpp

@@ -838 +838 @@
     va_list va;
     va_start(va, pcszCommand);
-    size_t cch = RTStrPrintfV(pThis->pszCommandBuffer, DRVCLOUDTUNNEL_COMMAND_BUFFER_SIZE, pcszCommand, va);
+    ssize_t const cch = RTStrPrintf2V(pThis->pszCommandBuffer, DRVCLOUDTUNNEL_COMMAND_BUFFER_SIZE, pcszCommand, va);
     va_end(va);
-    if (cch == 0)  /** @todo r=bird: WTF is this supposed to be? Checking for empty pcszCommand? */
+    if (cch <= 0)
     {
         Log(("%s: Failed to process '%s'\n", pThis->pszInstance, pcszCommand));
@@ -880 +880 @@
     va_list va;
     va_start(va, pcszCommand);
-    size_t cch = RTStrPrintfV(pThis->pszCommandBuffer, DRVCLOUDTUNNEL_COMMAND_BUFFER_SIZE, pcszCommand, va);
+    ssize_t const cch = RTStrPrintf2V(pThis->pszCommandBuffer, DRVCLOUDTUNNEL_COMMAND_BUFFER_SIZE, pcszCommand, va);
     va_end(va);
-    if (cch == 0) /** @todo r=bird: WTF is this supposed to be? Checking for empty pcszCommand? */
+    if (cch <= 0)
     {
         Log(("%s: Failed to process '%s'\n", pThis->pszInstance, pcszCommand));