Changeset 103359 in vbox for trunk/src/VBox/VMM/VMMR3

Timestamp:

Feb 14, 2024 2:39:26 PM (11 months ago)

Author:

vboxsync

Message:

VMM/DBGF,PDMLdr,PGM: Addressed parfait's complaints about uninitialized variables. bugref:3409

Location:

trunk/src/VBox/VMM/VMMR3

Files:

• DBGFAddr.cpp (modified) (1 diff)
• PDMLdr.cpp (modified) (1 diff)
• PGMDbg.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR3/DBGFAddr.cpp

@@ -240 +240 @@
 {
     VMCPU_ASSERT_EMT(pVCpu);
-    /* This is just a wrapper because we cannot pass FlatPtr thru VMR3ReqCall directly. */
-    PGMPTWALK Walk;
+    PGMPTWALK Walk = { NIL_RTGCPTR, NIL_RTGCPHYS, NIL_RTGCPHYS, false };
     int const rc = PGMGstGetPage(pVCpu, pAddress->FlatPtr, &Walk);
     *pGCPhys = Walk.GCPhys;

trunk/src/VBox/VMM/VMMR3/PDMLdr.cpp

@@ -714 +714 @@
      * Ask the support library to load it.
      */
-    void           *pvImageBase;
     RTERRINFOSTATIC ErrInfo;
-    RTErrInfoInitStatic(&ErrInfo);
-    int rc = SUPR3LoadModule(pszFilename, pszName, &pvImageBase, &ErrInfo.Core);
+    void           *pvImageBase = NULL;
+    int rc = SUPR3LoadModule(pszFilename, pszName, &pvImageBase, RTErrInfoInitStatic(&ErrInfo));
     if (RT_SUCCESS(rc))
     {

trunk/src/VBox/VMM/VMMR3/PGMDbg.cpp

@@ -1007 +1007 @@
     uint32_t        cYieldCountDown         = cYieldCountDownReload;
     RTGCPHYS        GCPhysPrev              = NIL_RTGCPHYS;
+    PGMPTWALK       Walk                    = { NIL_RTGCPTR, NIL_RTGCPHYS, NIL_RTGCPHYS, false };
+    PGMPTWALKGST    WalkGst                 = { {}, PGMPTWALKGSTTYPE_INVALID };
     bool            fFullWalk               = true;
-    PGMPTWALK       Walk;
-    PGMPTWALKGST    WalkGst;
 
     PGM_LOCK_VOID(pVM);
     for (;; offPage = 0)
     {
-        int rc;
+        int             rc;
         if (fFullWalk)
             rc = pgmGstPtWalk(pVCpu, GCPtr, &Walk, &WalkGst);