Changeset 103431 in vbox

Timestamp:

Feb 19, 2024 12:06:37 PM (9 months ago)

Author:

vboxsync

Message:

tstIntNet-1: RTStrCat won't fail because we already subtracted the size of the string-to-append from the buffer size in the RTPathExecDir call. Just use memcpy to avoid upsetting anyone. bugref:3409

File:

• trunk/src/VBox/Devices/Network/testcase/tstIntNet-1.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Network/testcase/tstIntNet-1.cpp

@@ -839 +839 @@
     }
 
-    char szPath[RTPATH_MAX];
-    rc = RTPathExecDir(szPath, sizeof(szPath) - sizeof("/../VMMR0.r0"));
+    static const char s_szVmmR0[] = "/../VMMR0.r0";
+    char              szPath[RTPATH_MAX];
+    rc = RTPathExecDir(szPath, sizeof(szPath) - sizeof(s_szVmmR0));
     if (RT_FAILURE(rc))
     {
@@ -846 +847 @@
         return 1;
     }
-
-    rc = RTStrCat(szPath, sizeof(szPath), "/../VMMR0.r0");
-    if (RT_FAILURE(rc))
-    {
-        RTPrintf("tstIntNet-1: RTStrCat -> %Rrc\n", rc);
-        return 1;
-    }
+    memcpy(strchr(szPath, '\0'), s_szVmmR0, sizeof(s_szVmmR0));
 
     char szAbsPath[RTPATH_MAX];