Changeset 103440 in vbox

Timestamp:

Feb 19, 2024 1:45:28 PM (9 months ago)

Author:

vboxsync

Message:

IPRT/tstRTR0CommonDriver.h: Buffer overflow for szSrvReqHandler is not possible, so simplified the code accordingly. bugref:3409

File:

• trunk/src/VBox/Runtime/testcase/tstRTR0CommonDriver.h (modified) (1 diff)

trunk/src/VBox/Runtime/testcase/tstRTR0CommonDriver.h

@@ -128 +128 @@
     }
 
-    char szSrvReqHandler[sizeof(g_szSrvName) + sizeof("SrvReqHandler")];
-    rc = RTStrCopy(szSrvReqHandler, sizeof(szSrvReqHandler), pszTestServiceName);
-    if (RT_SUCCESS(rc))
-        rc = RTStrCat(szSrvReqHandler, sizeof(szSrvReqHandler), "SrvReqHandler");
-    if (RT_FAILURE(rc))
-    {
-        RTTestFailed(g_hTest, "RTStrCat failed with rc=%Rrc\n", rc);
-        return RTTestSummaryAndDestroy(g_hTest);
-    }
-
+    static char const s_szSrvReqHandlerSuff[] = "SrvReqHandler";
+    char szSrvReqHandler[sizeof(g_szSrvName) + sizeof(s_szSrvReqHandlerSuff)];
+    memcpy(mempcpy(szSrvReqHandler, g_szSrvName, g_cchSrvName), s_szSrvReqHandlerSuff, sizeof(s_szSrvReqHandlerSuff));
     for (size_t off = 0; RT_C_IS_LOWER(szSrvReqHandler[off]); off++)
         szSrvReqHandler[off] = RT_C_TO_UPPER(szSrvReqHandler[off]);