Changeset 10351 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Jul 8, 2008 9:04:25 AM (16 years ago)

Author:

vboxsync

Message:

FE/Qt: Cache values used several times in local variables (IPC calls may be expensive).

File:

• trunk/src/VBox/Frontends/VirtualBox/ui/VBoxNewVMWzd.ui.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/ui/VBoxNewVMWzd.ui.h

@@ -329 +329 @@
     CGuestOSType type = vboxGlobal().vmGuestOSType (cbOS->currentItem());
     AssertMsg (!type.isNull(), ("vmGuestOSType() must return non-null type"));
-    cmachine.SetOSTypeId (type.GetId());
-
-    if (type.GetId() == "os2warp3"  ||
-        type.GetId() == "os2warp4"  ||
-        type.GetId() == "os2warp45" ||
-        type.GetId() == "ecs")
+    QString typeId = type.GetId();
+    cmachine.SetOSTypeId (typeId);
+
+    if (typeId == "os2warp3"  ||
+        typeId == "os2warp4"  ||
+        typeId == "os2warp45" ||
+        typeId == "ecs")
         cmachine.SetHWVirtExEnabled (KTSBool_True);
 
@@ -345 +346 @@
 #ifdef VBOX_WITH_E1000
         /* Default to e1k on solaris */
-        if (type.GetId() == "solaris" ||
-            type.GetId() == "opensolaris")
+        if (typeId == "solaris" ||
+            typeId == "opensolaris")
             cadapter.SetAdapterType (KNetworkAdapterType_I82540EM);
 #endif /* VBOX_WITH_E1000 */