Changeset 103510 in vbox

Timestamp:

Feb 21, 2024 9:34:34 PM (9 months ago)

Author:

vboxsync

Message:

parfait: Start including a baseline of reports which are either false positives or not worth fixing, bugref:3409

While parfait has the ability to annotate source code to suppress certain defect types for code through Parfait_ALLOW
it is mostly unsuitable for us as the code triggering the report needs to be annotated instead of the origin of the report
(imagine a chain of calls where a condition at the top which is a false assumption by parfait might trigger a report at the
end of the call chain in a library function). Annotating the code would silence all reports of this type which is not what we want,
especially for functions in libraries.
Flagging the reports on the server is also not feasible because they are not taken into account when running parfait locally.
So the next best thing is to feed the baseline of reports to ignore to parfait using a text file which is tedious to create because
one has to extract the report checksum from report.txt and add it to the baseline. Hopefully this is mostly a once in a lifetime task
for the initial baseline and will be much less work in the future.

File:

• trunk/Makefile.kmk (modified) (1 diff)

trunk/Makefile.kmk

@@ -2522 +2522 @@
          $(if-expr defined(VBOX_PARFAIT_SERVER),-s $(VBOX_PARFAIT_SERVER),) \
          $(VBOX_PARFAIT_OPTS) \
-         $(if-expr defined(VBOX_PARFAIT_SERVER_BASELINE),-b $(VBOX_PARFAIT_SERVER_BASELINE),) \
+         $(if-expr defined(VBOX_PARFAIT_SERVER_BASELINE),-b $(VBOX_PARFAIT_SERVER_BASELINE),-b $(PATH_ROOT)/tools/parfait-vbox-baseline.conf) \
          -j $(if-expr $(KMK_OPTS_JOBS) > 0, $(KMK_OPTS_JOBS), 1) \
          -o $(PATH_OUT)/report.txt \