Changeset 103535 in vbox

Timestamp:

Feb 22, 2024 3:26:55 PM (9 months ago)

Author:

vboxsync

Message:

VMM/IEM: Quick hack for catching and dealing with pbInstrBuf == NULL (extremely unlikely) and avoid the memcmp crash. bugref:10370

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllThrdRecompiler.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllThrdRecompiler.cpp

@@ -2707 +2707 @@
 
                 pTb = iemTbCacheLookup(pVCpu, pTbCache, GCPhysPc, fExtraFlags);
-                if (pTb)
-                    rcStrict = iemTbExec(pVCpu, pTb);
+                if (RT_LIKELY(pVCpu->iem.s.pbInstrBuf != NULL))
+                {
+                    if (pTb)
+                        rcStrict = iemTbExec(pVCpu, pTb);
+                    else
+                        rcStrict = iemThreadedCompile(pVM, pVCpu, GCPhysPc, fExtraFlags);
+                }
                 else
-                    rcStrict = iemThreadedCompile(pVM, pVCpu, GCPhysPc, fExtraFlags);
+                {
+                    /* This can only happen if the current PC cannot be translated into a
+                       host pointer, which means we're in MMIO or unmapped memory... */
+#if defined(VBOX_STRICT) && defined(IN_RING3)
+                    rcStrict = DBGFSTOP(pVM);
+                    if (rcStrict != VINF_SUCCESS && rcStrict != VERR_DBGF_NOT_ATTACHED)
+                        return rcStrict;
+#endif
+                    rcStrict = IEMExecLots(pVCpu, 2048, cPollRate, NULL);
+                }
                 if (rcStrict == VINF_SUCCESS)
                 {