Changeset 103573 in vbox

Timestamp:

Feb 26, 2024 2:49:40 PM (9 months ago)

Author:

vboxsync

Message:

libs/xpcom: Replace the old ipcMessageWriter helper class with an inline version to avoid function calls in hot code paths, bugref:10597 [fixes for 0 byte memory allocation]

File:

• trunk/src/libs/xpcom18a4/ipc/ipcd/client/src/ipcDConnectService.cpp (modified) (2 diffs)

trunk/src/libs/xpcom18a4/ipc/ipcd/client/src/ipcDConnectService.cpp

@@ -2525 +2525 @@
 
   IPCMSGWRITER MsgWriter;
-  IPCMsgWriterInit(&MsgWriter, 16 * paramCount);
+  IPCMsgWriterInit(&MsgWriter, 64 + 16 * paramCount);
 
   // INVOKE message header
@@ -3702 +3702 @@
   Log(("  request-index=%d\n", (PRUint32) invoke->request_index));
 
-  params = (nsXPTCVariant *)RTMemAllocZ(sizeof(nsXPTCVariant) * paramCount);
-  if (!params)
-  {
-    rv = NS_ERROR_OUT_OF_MEMORY;
-    goto end;
+  if (paramCount)
+  {
+    params = (nsXPTCVariant *)RTMemAllocZ(sizeof(nsXPTCVariant) * paramCount);
+    if (!params)
+    {
+      rv = NS_ERROR_OUT_OF_MEMORY;
+      goto end;
+    }
   }