Changeset 103610 in vbox

Timestamp:

Feb 29, 2024 9:35:50 AM (9 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10611: Global preferences / General page: Adding page validation; Make sure Default machine folder present if changed; Prevent Global Preferences from being accepted otherwise.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings

Files:

• editors/UIDefaultMachineFolderEditor.cpp (modified) (1 diff)
• editors/UIDefaultMachineFolderEditor.h (modified) (1 diff)
• global/UIGlobalSettingsGeneral.cpp (modified) (4 diffs)
• global/UIGlobalSettingsGeneral.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIDefaultMachineFolderEditor.cpp

@@ -107 +107 @@
                 m_pLabel->setBuddy(m_pSelector);
             m_pSelector->setInitialPath(uiCommon().homeFolder());
+            connect(m_pSelector, &UIFilePathSelector::pathChanged,
+                    this, &UIDefaultMachineFolderEditor::sigPathChanged);
 
             m_pLayout->addWidget(m_pSelector, 0, 1);

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIDefaultMachineFolderEditor.h

@@ -45 +45 @@
     Q_OBJECT;
 
+signals:
+
+    /** Notify listeners about @a strPath changed. */
+    void sigPathChanged(const QString &strPath);
+
 public:
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsGeneral.cpp

@@ -27 +27 @@
 
 /* Qt includes: */
+#include <QDir>
 #include <QVBoxLayout>
 
@@ -123 +124 @@
     if (m_pEditorVRDEAuthLibrary)
         m_pEditorVRDEAuthLibrary->setValue(oldData.m_strVRDEAuthLibrary);
+
+    /* Revalidate: */
+    revalidate();
 }
 
@@ -154 +158 @@
 }
 
+bool UIGlobalSettingsGeneral::validate(QList<UIValidationMessage> &messages)
+{
+    /* Pass by default: */
+    bool fPass = true;
+
+    /* Prepare message: */
+    UIValidationMessage message;
+
+    /* Check for the folder presence: */
+    if (   m_pEditorDefaultMachineFolder
+        && !QDir(m_pEditorDefaultMachineFolder->value()).exists())
+    {
+        message.second << tr("Default machine folder is missing.");
+        fPass = false;
+    }
+
+    /* Serialize message: */
+    if (!message.second.isEmpty())
+        messages << message;
+
+    /* Return result: */
+    return fPass;
+}
+
 void UIGlobalSettingsGeneral::retranslateUi()
 {
@@ -189 +217 @@
             addEditor(m_pEditorDefaultMachineFolder);
             pLayout->addWidget(m_pEditorDefaultMachineFolder);
+            connect(m_pEditorDefaultMachineFolder, &UIDefaultMachineFolderEditor::sigPathChanged,
+                    this, &UIGlobalSettingsGeneral::revalidate);
         }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsGeneral.h

@@ -72 +72 @@
     virtual void saveFromCacheTo(QVariant &data) RT_OVERRIDE;
 
+    /** Performs validation, updates @a messages list if something is wrong. */
+    virtual bool validate(QList<UIValidationMessage> &messages) RT_OVERRIDE;
+
     /** Handles translation event. */
     virtual void retranslateUi() RT_OVERRIDE;