Changeset 103624 in vbox

Timestamp:

Mar 1, 2024 12:45:18 AM (9 months ago)

Author:

vboxsync

Message:

VMM/IEM: Must release variable register when done with them. bugref:10371

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp

@@ -13551 +13551 @@
     IEMNATIVE_ASSERT_VAR_SIZE(pReNative, idxDstVar, sizeof(uint16_t));
 
+    uint8_t const idxReg = iemNativeVarRegisterAcquire(pReNative, idxDstVar, &off);
+
     /* Allocate a temporary FCW register. */
-    uint8_t const idxReg = iemNativeVarRegisterAcquire(pReNative, idxDstVar, &off, false /*fInitialized*/);
-    uint8_t const idxFcwReg = iemNativeRegAllocTmpForGuestReg(pReNative, &off, kIemNativeGstReg_FpuFcw, kIemNativeGstRegUse_ReadOnly);
+    /** @todo eliminate extra register   */
+    uint8_t const idxFcwReg = iemNativeRegAllocTmpForGuestReg(pReNative, &off, kIemNativeGstReg_FpuFcw,
+                                                              kIemNativeGstRegUse_ReadOnly);
 
     off = iemNativeEmitLoadGprFromGpr16(pReNative, off, idxReg, idxFcwReg);
@@ -13559 +13562 @@
     /* Free but don't flush the FCW register. */
     iemNativeRegFreeTmp(pReNative, idxFcwReg);
+    iemNativeVarRegisterRelease(pReNative, idxDstVar);
 
     return off;
@@ -13574 +13578 @@
     IEMNATIVE_ASSERT_VAR_SIZE(pReNative, idxDstVar, sizeof(uint16_t));
 
+    uint8_t const idxReg = iemNativeVarRegisterAcquire(pReNative, idxDstVar, &off, false /*fInitialized*/);
     /* Allocate a temporary FSW register. */
-    uint8_t const idxReg = iemNativeVarRegisterAcquire(pReNative, idxDstVar, &off, false /*fInitialized*/);
-    uint8_t const idxFswReg = iemNativeRegAllocTmpForGuestReg(pReNative, &off, kIemNativeGstReg_FpuFsw, kIemNativeGstRegUse_ReadOnly);
+    /** @todo eliminate extra register   */
+    uint8_t const idxFswReg = iemNativeRegAllocTmpForGuestReg(pReNative, &off, kIemNativeGstReg_FpuFsw,
+                                                              kIemNativeGstRegUse_ReadOnly);
 
     off = iemNativeEmitLoadGprFromGpr16(pReNative, off, idxReg, idxFswReg);
@@ -13582 +13588 @@
     /* Free but don't flush the FSW register. */
     iemNativeRegFreeTmp(pReNative, idxFswReg);
+    iemNativeVarRegisterRelease(pReNative, idxDstVar);
 
     return off;