Changeset 103811 in vbox

Timestamp:

Mar 12, 2024 9:45:22 PM (10 months ago)

Author:

vboxsync

Message:

VMM/IEM: Fix the SIMD register check code on amd64, bugref:10614

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp

@@ -5980 +5980 @@
     /* pcmpeqq vectmp0, [gstreg] (ASSUMES SSE4.1) */
     pbCodeBuf[off++] = X86_OP_PRF_SIZE_OP;
-    if (idxSimdReg >= 8)
+    if (IEMNATIVE_SIMD_REG_FIXED_TMP0 >= 8)
         pbCodeBuf[off++] = X86_OP_REX_R;
     pbCodeBuf[off++] = 0x0f;
     pbCodeBuf[off++] = 0x38;
     pbCodeBuf[off++] = 0x29;
-    off = iemNativeEmitGprByVCpuDisp(pbCodeBuf, off, idxSimdReg, g_aGstSimdShadowInfo[enmGstSimdReg].offXmm);
+    off = iemNativeEmitGprByVCpuDisp(pbCodeBuf, off, IEMNATIVE_SIMD_REG_FIXED_TMP0, g_aGstSimdShadowInfo[enmGstSimdReg].offXmm);
 
     /* pextrq tmp0, vectmp0, #0 (ASSUMES SSE4.1). */
@@ -5998 +5998 @@
     pbCodeBuf[off++] = 0x00;
 
-    /* test tmp0, 0xffffffff. */
+    /* cmp tmp0, 0xffffffffffffffff. */
     pbCodeBuf[off++] = X86_OP_REX_W | (IEMNATIVE_REG_FIXED_TMP0 < 8 ? 0 : X86_OP_REX_B);
-    pbCodeBuf[off++] = 0xf7;
-    pbCodeBuf[off++] = X86_MODRM_MAKE(X86_MOD_REG, 0, IEMNATIVE_REG_FIXED_TMP0 & 7);
-    pbCodeBuf[off++] = 0xff;
-    pbCodeBuf[off++] = 0xff;
-    pbCodeBuf[off++] = 0xff;
+    pbCodeBuf[off++] = 0x83;
+    pbCodeBuf[off++] = X86_MODRM_MAKE(X86_MOD_REG, 7, IEMNATIVE_REG_FIXED_TMP0 & 7);
     pbCodeBuf[off++] = 0xff;
 
@@ -6025 +6022 @@
     pbCodeBuf[off++] = 0x01;
 
-    /* test tmp0, 0xffffffff. */
+    /* cmp tmp0, 0xffffffffffffffff. */
     pbCodeBuf[off++] = X86_OP_REX_W | (IEMNATIVE_REG_FIXED_TMP0 < 8 ? 0 : X86_OP_REX_B);
-    pbCodeBuf[off++] = 0xf7;
-    pbCodeBuf[off++] = X86_MODRM_MAKE(X86_MOD_REG, 0, IEMNATIVE_REG_FIXED_TMP0 & 7);
-    pbCodeBuf[off++] = 0xff;
-    pbCodeBuf[off++] = 0xff;
-    pbCodeBuf[off++] = 0xff;
+    pbCodeBuf[off++] = 0x83;
+    pbCodeBuf[off++] = X86_MODRM_MAKE(X86_MOD_REG, 7, IEMNATIVE_REG_FIXED_TMP0 & 7);
     pbCodeBuf[off++] = 0xff;