Changeset 103865 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Mar 15, 2024 11:56:15 AM (9 months ago)

Author:

vboxsync

Message:

VMM/IEM: Implement native emitter for IEM_MC_CALL_SSE_AIMPL_2()/IEM_MC_CALL_SSE_AIMPL_3(), bugref:10614

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• IEMAllInstPython.py (modified) (1 diff)
• IEMAllN8veRecompFuncs.h (modified) (1 diff)
• IEMAllN8veRecompiler.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllInstPython.py

@@ -2987 +2987 @@
     'IEM_MC_CALL_MMX_AIMPL_2':                                   (McBlock.parseMcCallMmxAImpl,      True,  True,  False, ),
     'IEM_MC_CALL_MMX_AIMPL_3':                                   (McBlock.parseMcCallMmxAImpl,      True,  True,  False, ),
-    'IEM_MC_CALL_SSE_AIMPL_2':                                   (McBlock.parseMcCallSseAImpl,      True,  True,  False, ),
-    'IEM_MC_CALL_SSE_AIMPL_3':                                   (McBlock.parseMcCallSseAImpl,      True,  True,  False, ),
+    'IEM_MC_CALL_SSE_AIMPL_2':                                   (McBlock.parseMcCallSseAImpl,      True,  True,  g_fNativeSimd),
+    'IEM_MC_CALL_SSE_AIMPL_3':                                   (McBlock.parseMcCallSseAImpl,      True,  True,  g_fNativeSimd),
     'IEM_MC_CALL_VOID_AIMPL_0':                                  (McBlock.parseMcCallVoidAImpl,     True,  True,  True,  ),
     'IEM_MC_CALL_VOID_AIMPL_1':                                  (McBlock.parseMcCallVoidAImpl,     True,  True,  True,  ),

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompFuncs.h

@@ -7478 +7478 @@
 }
 
+
+
+/*********************************************************************************************************************************
+*   Emitters for IEM_MC_CALL_SSE_AIMPL_XXX                                                                                       *
+*********************************************************************************************************************************/
+
+/**
+ * Common worker for IEM_MC_CALL_SSE_AIMPL_XXX.
+ */
+DECL_INLINE_THROW(uint32_t)
+iemNativeEmitCallSseAImplCommon(PIEMRECOMPILERSTATE pReNative, uint32_t off, uintptr_t pfnAImpl, uint8_t cArgs)
+{
+    /*
+     * Need to do the FPU preparation.
+     */
+    off = iemNativeEmitPrepareFpuForUse(pReNative, off, true /*fForChange*/);
+
+    /*
+     * Do all the call setup and cleanup.
+     */
+    off = iemNativeEmitCallCommon(pReNative, off, cArgs + IEM_SSE_AIMPL_HIDDEN_ARGS, IEM_SSE_AIMPL_HIDDEN_ARGS);
+
+    /*
+     * Load the XState::x87 pointer.
+     */
+    off = iemNativeEmitLeaGprByGstRegRef(pReNative, off, IEMNATIVE_CALL_ARG0_GREG, kIemNativeGstRegRef_X87, 0 /*idxRegInClass*/);
+
+    /*
+     * Make the call.
+     */
+    off = iemNativeEmitCallImm(pReNative, off, pfnAImpl);
+
+    return off;
+}
+
+
+
+#define IEM_MC_CALL_SSE_AIMPL_2(a_pfnAImpl, a0, a1) \
+    off = iemNativeEmitCallSseAImplCommon(pReNative, off, (uintptr_t)(a_pfnAImpl), 2)
+
+#define IEM_MC_CALL_SSE_AIMPL_3(a_pfnAImpl, a0, a1, a3) \
+    off = iemNativeEmitCallSseAImplCommon(pReNative, off, (uintptr_t)(a_pfnAImpl), 3)
 #endif /* IEMNATIVE_WITH_SIMD_REG_ALLOCATOR */
 

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp

@@ -3356 +3356 @@
     AssertStmt(   enmType != kIemNativeFixupType_RelImm14At5
                || pReNative->paLabels[idxLabel].enmType >= kIemNativeLabelType_FirstWithMultipleInstances
-               || pReNative->paLabels[idxLabel].off != UINT32_MAX,
+               || pReNative->paLabels[idxLabel].off == UINT32_MAX,
                IEMNATIVE_DO_LONGJMP(pReNative, VERR_IEM_FIXUP_SHORT_JMP_TO_TAIL_LABEL));
 #endif
@@ -7692 +7692 @@
  * Emits code to load a reference to the given guest register into @a idxGprDst.
   */
-DECL_INLINE_THROW(uint32_t)
+DECL_HIDDEN_THROW(uint32_t)
 iemNativeEmitLeaGprByGstRegRef(PIEMRECOMPILERSTATE pReNative, uint32_t off, uint8_t idxGprDst,
                                IEMNATIVEGSTREGREF enmClass, uint8_t idxRegInClass)
@@ -7741 +7741 @@
             Assert(idxRegInClass < 16);
             offCpumCtx = RT_UOFFSETOF_DYN(CPUMCTX, XState.x87.aXMM[idxRegInClass]);
+            break;
+
+        case kIemNativeGstRegRef_X87: /* Not a register actually but we would just duplicate code otherwise. */
+            Assert(idxRegInClass == 0);
+            offCpumCtx = RT_UOFFSETOF(CPUMCTX, XState.x87);
+            break;
+
+        case kIemNativeGstRegRef_XState: /* Not a register actually but we would just duplicate code otherwise. */
+            Assert(idxRegInClass == 0);
+            offCpumCtx = RT_UOFFSETOF(CPUMCTX, XState);
             break;