Changeset 103870 in vbox

Timestamp:

Mar 15, 2024 3:53:33 PM (12 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

162241

Message:

FE/Qt: bugref:10384: UIGuestOSType: Cache whether OS type is supported; That allows to exclude unwanted types in OS type editor while still keeping them cached.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/globals

Files:

• UIGuestOSType.cpp (modified) (3 diffs)
• UIGuestOSType.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIGuestOSType.cpp

@@ -81 +81 @@
 void UIGuestOSTypeManager::addGuestOSType(const CGuestOSType &comType)
 {
+    /* Acquire guest OS type ID and whether it's supported: */
+    const QString strId = comType.GetId();
+    const bool fSupported = m_supportedGuestOSTypeIDs.contains(strId);
+
     /* Append guest OS type to a list of cached wrappers: */
-    m_guestOSTypes.append(UIGuestOSType(comType));
+    m_guestOSTypes.append(UIGuestOSType(comType, fSupported));
 
     /* Acquire a bit of attributes: */
-    const QString strId = m_guestOSTypes.last().getId();
     const QString strFamilyId = m_guestOSTypes.last().getFamilyId();
     const QString strFamilyDesc = m_guestOSTypes.last().getFamilyDescription();
     const QString strSubtype = m_guestOSTypes.last().getSubtype();
     const KPlatformArchitecture enmArch = m_guestOSTypes.last().getPlatformArchitecture();
-    const bool fSupported = m_supportedGuestOSTypeIDs.contains(strId);
 
     /* Remember guest OS type index as well: */
@@ -312 +314 @@
 
 UIGuestOSType::UIGuestOSType()
-{
-}
-
-UIGuestOSType::UIGuestOSType(const CGuestOSType &comGuestOSType)
+    : m_fSupported(false)
+{
+}
+
+UIGuestOSType::UIGuestOSType(const CGuestOSType &comGuestOSType, bool fSupported)
     : m_comGuestOSType(comGuestOSType)
+    , m_fSupported(fSupported)
 {
 }
@@ -323 +327 @@
 {
     return (!m_comGuestOSType.isNull() && m_comGuestOSType.isOk());
+}
+
+bool UIGuestOSType::isSupported() const
+{
+    return m_fSupported;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIGuestOSType.h

@@ -121 +121 @@
 public:
 
-    UIGuestOSType(const CGuestOSType &comGuestOSType);
+    UIGuestOSType(const CGuestOSType &comGuestOSType, bool fSupported);
     UIGuestOSType();
+
+    bool isSupported() const;
 
     const QString &getFamilyId() const;
@@ -149 +151 @@
 private:
 
+    CGuestOSType m_comGuestOSType;
+
+    bool m_fSupported;
+
     /** @name CGuestOSType properties. Cached here for a faster access.
       * @{ */
@@ -157 +163 @@
         mutable QString m_strDescription;
     /** @} */
-
-    CGuestOSType m_comGuestOSType;
 };