Changeset 103873 in vbox

Timestamp:

Mar 16, 2024 1:04:36 AM (9 months ago)

Author:

vboxsync

Message:

ValKit/bs3-cpu-instr-3: A more optimal use of BS3_THRESHOLD_NATIVE_RECOMPILER in bs3-cpu-instr-3. bugref:10614

File:

• trunk/src/VBox/ValidationKit/bootsectors/bs3-cpu-instr-3.c32 (modified) (13 diffs)

trunk/src/VBox/ValidationKit/bootsectors/bs3-cpu-instr-3.c32

@@ -569 +569 @@
  * (to enable this: turn on `#define BS3_SKIPIT_DO_ARGS': which costs about
  * 3% performance).
+ *
+ * Note! The skipping is not compatible with testing the native recompiler as
+ *       it requires the test code to be run a number of times before it kicks
+ *       in and does the native recompilation (currently around 16 times).
  */
 #define BS3_SKIPIT_AVG_SKIP 26
@@ -776 +780 @@
                  * Iterate the test values and do the actual testing.
                  */
-                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER * 2)
-                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++)
+                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER + cValues)
+                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++, cRecompRuns++)
                     {
                         uint16_t   cErrors;
@@ -784 +788 @@
 
                         if (BS3_SKIPIT(bRing, iCfg, iTest, iVal, 0)) continue;
-                        cRecompRuns++;
 
                         /*
@@ -9254 +9257 @@
                  * Iterate the test values and do the actual testing.
                  */
-                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER * 2)
-                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++)
+                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER + cValues)
+                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++, cRecompRuns++)
                     {
                         uint16_t   cErrors;
@@ -9262 +9265 @@
 
                         if (BS3_SKIPIT(bRing, iCfg, iTest, iVal, 0)) continue;
-                        cRecompRuns++;
 
                         /*
@@ -9932 +9934 @@
                  * Iterate the test values and do the actual testing.
                  */
-                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER * 2)
-                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++)
+                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER + cValues)
+                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++, cRecompRuns++)
                     {
                         uint16_t   cErrors;
@@ -9940 +9942 @@
 
                         if (BS3_SKIPIT(bRing, iCfg, iTest, iVal, 0)) continue;
-                        cRecompRuns++;
 
                         /*
@@ -12141 +12142 @@
                  * Iterate the test values and do the actual testing.
                  */
-                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER * 2)
-                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++)
+                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER + cValues * 2)
+                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++, cRecompRuns++)
                     {
                         unsigned       iEflVariation;
@@ -12153 +12154 @@
 
                             if (BS3_SKIPIT(bRing, iCfg, iTest, iVal, iEflVariation)) continue;
-                            cRecompRuns++;
 
                             /*
@@ -12471 +12471 @@
                  * Iterate the test values and do the actual testing.
                  */
-                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER * 2)
-                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++)
+                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER + cValues)
+                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++, cRecompRuns++)
                     {
                         uint16_t   cErrors;
@@ -12479 +12479 @@
 
                         if (BS3_SKIPIT(bRing, iCfg, iTest, iVal, 0)) continue;
-                        cRecompRuns++;
 
                         /*
@@ -13039 +13038 @@
                  * Iterate the test values and do the actual testing.
                  */
-                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER * 2)
-                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++)
+                while (cRecompRuns < BS3_THRESHOLD_NATIVE_RECOMPILER + cValues)
+                    for (iVal = 0; iVal < cValues; iVal++, idTestStep++, cRecompRuns++)
                     {
                         uint16_t   cErrors;
@@ -13047 +13046 @@
 
                         if (BS3_SKIPIT(bRing, iCfg, iTest, iVal, 0)) continue;
+
                         /*
                          * Set up the context and some expectations.