Changeset 103876 in vbox

Timestamp:

Mar 16, 2024 2:11:04 AM (11 months ago)

Author:

vboxsync

Message:

VMM/IEM: Reverted silent assertion 'fix' from r162236 as it is wrong (explained this on IRC already). Removed the check of 'off' altogether as it is wrong even if someone defines the label early, say for the first instruction, other may still jump to it from the last instruction in the TB, so the same jump restrictions apply. bugref:10614 bugref:10370

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAllN8veRecompiler.cpp (modified) (1 diff)
• include/IEMN8veRecompiler.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp

@@ -3355 +3355 @@
 #ifdef RT_ARCH_ARM64
     AssertStmt(   enmType != kIemNativeFixupType_RelImm14At5
-               || pReNative->paLabels[idxLabel].enmType >= kIemNativeLabelType_FirstWithMultipleInstances
-               || pReNative->paLabels[idxLabel].off == UINT32_MAX,
+               || pReNative->paLabels[idxLabel].enmType >= kIemNativeLabelType_LastWholeTbBranch,
                IEMNATIVE_DO_LONGJMP(pReNative, VERR_IEM_FIXUP_SHORT_JMP_TO_TAIL_LABEL));
 #endif

trunk/src/VBox/VMM/include/IEMN8veRecompiler.h

@@ -421 +421 @@
     kIemNativeLabelType_ReturnWithFlags,
     kIemNativeLabelType_NonZeroRetOrPassUp,
+    /** The last fixup for branches that can span almost the whole TB length. */
+    kIemNativeLabelType_LastWholeTbBranch = kIemNativeLabelType_NonZeroRetOrPassUp,
 
     /*