Changeset 10391 in vbox for trunk/src

Timestamp:

Jul 8, 2008 10:19:04 PM (17 years ago)

Author:

vboxsync

Message:

Override IOService::terminate to prevent a busy VBoxDrv from being half unloaded and crash the system.

File:

• trunk/src/VBox/HostDrivers/Support/darwin/SUPDrv-darwin.cpp (modified) (7 diffs)

trunk/src/VBox/HostDrivers/Support/darwin/SUPDrv-darwin.cpp

@@ -108 +108 @@
     virtual void stop(IOService *pProvider);
     virtual IOService *probe(IOService *pProvider, SInt32 *pi32Score);
+    virtual bool terminate(IOOptionBits fOptions);
 };
 
@@ -196 +197 @@
 /** Calculates the index into g_apSessionHashTab.*/
 #define SESSION_HASH(pid)     ((pid) % RT_ELEMENTS(g_apSessionHashTab))
+/** The number of open sessions. */
+static int32_t volatile g_cSessions = 0;
 
 
@@ -202 +205 @@
  * rest of the kernel modules on darwin.
  */
-extern PFNRT g_apfnVBoxDrvIPRTDeps[] =
+PFNRT g_apfnVBoxDrvIPRTDeps[] =
 {
     (PFNRT)RTUuidCompare,
@@ -352 +355 @@
         pSession->pNextHash = g_apSessionHashTab[iHash];
         g_apSessionHashTab[iHash] = pSession;
+        ASMAtomicIncS32(&g_cSessions);
         RTSpinlockReleaseNoInts(g_Spinlock, &Tmp);
     }
@@ -387 +391 @@
             g_apSessionHashTab[iHash] = pSession->pNextHash;
             pSession->pNextHash = NULL;
+            ASMAtomicIncS32(&g_cSessions);
         }
         else
@@ -398 +403 @@
                     pPrev->pNextHash = pSession->pNextHash;
                     pSession->pNextHash = NULL;
+                    ASMAtomicIncS32(&g_cSessions);
                     break;
                 }
@@ -827 +833 @@
     dprintf(("org_virtualbox_SupDrv::stop([%p], %p)\n", this, pProvider));
     IOService::stop(pProvider);
+}
+
+
+/**
+ * Termination request.
+ *
+ * @return  true if we're ok with shutting down now, false if we're not.
+ * @param   fOptions        Flags.
+ */
+bool org_virtualbox_SupDrv::terminate(IOOptionBits fOptions)
+{
+    bool fRc;
+    dprintf(("org_virtualbox_SupDrv::terminate: reference_count=%d g_cSessions=%d\n",
+             KMOD_INFO_NAME.reference_count, ASMAtomicUoReadS32(&g_cSessions)));
+    if (    KMOD_INFO_NAME.reference_count != 0
+        ||  ASMAtomicUoReadS32(&g_cSessions))
+        fRc = false;
+    else
+        fRc = IOService::terminate(fOptions);
+    dprintf(("org_virtualbox_SupDrv::terminate: returns %d\n", fRc));
+    return fRc;
 }