Changeset 104021 in vbox for trunk

Timestamp:

Mar 24, 2024 4:27:34 PM (12 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

162409

Message:

VMM/IEM: Implement native emitters for IEM_MC_CALL_AVX_AIMPL_2() and IEM_MC_CALL_AVX_AIMPL_3(), bugref:10614

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAllInstPython.py (modified) (1 diff)
• VMMAll/IEMAllN8vePython.py (modified) (1 diff)
• VMMAll/IEMAllN8veRecompFuncs.h (modified) (1 diff)
• VMMAll/IEMAllThrdPython.py (modified) (1 diff)
• include/IEMN8veRecompiler.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllInstPython.py

@@ -2993 +2993 @@
     'IEM_MC_CALL_AIMPL_3':                                       (McBlock.parseMcCallAImpl,         True,  True,  True,  ),
     'IEM_MC_CALL_AIMPL_4':                                       (McBlock.parseMcCallAImpl,         True,  True,  True,  ),
-    'IEM_MC_CALL_AVX_AIMPL_2':                                   (McBlock.parseMcCallAvxAImpl,      True,  True,  False, ),
-    'IEM_MC_CALL_AVX_AIMPL_3':                                   (McBlock.parseMcCallAvxAImpl,      True,  True,  False, ),
+    'IEM_MC_CALL_AVX_AIMPL_2':                                   (McBlock.parseMcCallAvxAImpl,      True,  True,  g_fNativeSimd),
+    'IEM_MC_CALL_AVX_AIMPL_3':                                   (McBlock.parseMcCallAvxAImpl,      True,  True,  g_fNativeSimd),
     'IEM_MC_CALL_CIMPL_0':                                       (McBlock.parseMcCallCImpl,         True,  True,  False, ),
     'IEM_MC_CALL_CIMPL_1':                                       (McBlock.parseMcCallCImpl,         True,  True,  False, ),

trunk/src/VBox/VMM/VMMAll/IEMAllN8vePython.py

@@ -388 +388 @@
                     #
                     asCallParams = oStmt.asParams[oStmt.idxParams:];
-                    if oStmt.sName.startswith('IEM_MC_CALL_AVX_AIMPL_'):
-                        asCallParams.insert(0, 'pXState');
                     for sParam in asCallParams:
                         oVarInfo = dVars.get(sParam);

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompFuncs.h

@@ -8464 +8464 @@
     return iemNativeEmitCallSseAImplCommon(pReNative, off, pfnAImpl, 3);
 }
+
+
+/*********************************************************************************************************************************
+*   Emitters for IEM_MC_CALL_AVX_AIMPL_XXX                                                                                       *
+*********************************************************************************************************************************/
+
+/**
+ * Common worker for IEM_MC_CALL_AVX_AIMPL_XXX.
+ */
+DECL_INLINE_THROW(uint32_t)
+iemNativeEmitCallAvxAImplCommon(PIEMRECOMPILERSTATE pReNative, uint32_t off, uintptr_t pfnAImpl, uint8_t cArgs)
+{
+    /*
+     * Need to do the FPU preparation.
+     */
+    off = iemNativeEmitPrepareFpuForUse(pReNative, off, true /*fForChange*/);
+
+    /*
+     * Do all the call setup and cleanup.
+     */
+    off = iemNativeEmitCallCommon(pReNative, off, cArgs + IEM_AVX_AIMPL_HIDDEN_ARGS, IEM_AVX_AIMPL_HIDDEN_ARGS);
+
+    /*
+     * Load the XState pointer.
+     */
+    off = iemNativeEmitLeaGprByGstRegRef(pReNative, off, IEMNATIVE_CALL_ARG0_GREG, kIemNativeGstRegRef_XState, 0 /*idxRegInClass*/);
+
+    /*
+     * Make the call.
+     */
+    off = iemNativeEmitCallImm(pReNative, off, pfnAImpl);
+
+    return off;
+}
+
+
+#define IEM_MC_CALL_AVX_AIMPL_2(a_pfnAImpl, a0, a1) \
+    off = iemNativeEmitCallAvxAImpl2(pReNative, off, (uintptr_t)(a_pfnAImpl), (a0), (a1))
+
+/** Emits code for IEM_MC_CALL_AVX_AIMPL_2. */
+DECL_INLINE_THROW(uint32_t)
+iemNativeEmitCallAvxAImpl2(PIEMRECOMPILERSTATE pReNative, uint32_t off, uintptr_t pfnAImpl, uint8_t idxArg0, uint8_t idxArg1)
+{
+    IEMNATIVE_ASSERT_ARG_VAR_IDX(pReNative, idxArg0, 0 + IEM_AVX_AIMPL_HIDDEN_ARGS);
+    IEMNATIVE_ASSERT_ARG_VAR_IDX(pReNative, idxArg1, 1 + IEM_AVX_AIMPL_HIDDEN_ARGS);
+    return iemNativeEmitCallAvxAImplCommon(pReNative, off, pfnAImpl, 2);
+}
+
+
+#define IEM_MC_CALL_AVX_AIMPL_3(a_pfnAImpl, a0, a1, a2) \
+    off = iemNativeEmitCallAvxAImpl3(pReNative, off, (uintptr_t)(a_pfnAImpl), (a0), (a1), (a2))
+
+/** Emits code for IEM_MC_CALL_AVX_AIMPL_3. */
+DECL_INLINE_THROW(uint32_t)
+iemNativeEmitCallAvxAImpl3(PIEMRECOMPILERSTATE pReNative, uint32_t off, uintptr_t pfnAImpl, uint8_t idxArg0, uint8_t idxArg1, uint8_t idxArg2)
+{
+    IEMNATIVE_ASSERT_ARG_VAR_IDX(pReNative, idxArg0, 0 + IEM_AVX_AIMPL_HIDDEN_ARGS);
+    IEMNATIVE_ASSERT_ARG_VAR_IDX(pReNative, idxArg1, 1 + IEM_AVX_AIMPL_HIDDEN_ARGS);
+    IEMNATIVE_ASSERT_ARG_VAR_IDX(pReNative, idxArg2, 2 + IEM_AVX_AIMPL_HIDDEN_ARGS);
+    return iemNativeEmitCallAvxAImplCommon(pReNative, off, pfnAImpl, 3);
+}
 #endif /* IEMNATIVE_WITH_SIMD_REG_ALLOCATOR */
 

trunk/src/VBox/VMM/VMMAll/IEMAllThrdPython.py

@@ -1974 +1974 @@
                     self.dsCImplFlags['IEM_CIMPL_F_CALLS_CIMPL'] = True;
                 elif (   oStmt.sName.startswith('IEM_MC_CALL_VOID_AIMPL_')
-                      or oStmt.sName.startswith('IEM_MC_CALL_AIMPL_')
-                      or oStmt.sName.startswith('IEM_MC_CALL_AVX_AIMPL_')):
+                      or oStmt.sName.startswith('IEM_MC_CALL_AIMPL_')):
                     self.dsCImplFlags['IEM_CIMPL_F_CALLS_AIMPL'] = True;
                 elif (   oStmt.sName.startswith('IEM_MC_CALL_SSE_AIMPL_')

trunk/src/VBox/VMM/include/IEMN8veRecompiler.h

@@ -1943 +1943 @@
 /** Number of hidden arguments for SSE_AIMPL calls. */
 # define IEM_SSE_AIMPL_HIDDEN_ARGS 1
+/** Number of hidden arguments for AVX_AIMPL calls. */
+# define IEM_AVX_AIMPL_HIDDEN_ARGS 1
 #endif