Changeset 104095 in vbox

Timestamp:

Mar 27, 2024 3:46:10 PM (12 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

162496

Message:

VMM/IEM: Release statistics on how often the exec memory allocator fails to allocate a large enough instruction buffer, bugref:10370

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAllN8veRecompiler.cpp (modified) (2 diffs)
• VMMR3/IEMR3.cpp (modified) (1 diff)
• include/IEMInternal.h (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp

@@ -508 +508 @@
     AssertMsgReturn(cbReq > 32 && cbReq < _512K, ("%#x\n", cbReq), NULL);
 
+    /*
+     * Adjust the request size so it'll fit the allocator alignment/whatnot.
+     *
+     * For the RTHeapSimple allocator this means to follow the logic described
+     * in iemExecMemAllocatorGrow and attempt to allocate it from one of the
+     * existing chunks if we think we've got sufficient free memory around.
+     *
+     * While for the alternative one we just align it up to a whole unit size.
+     */
+#ifdef IEMEXECMEM_USE_ALT_SUB_ALLOCATOR
+    cbReq = RT_ALIGN_32(cbReq, IEMEXECMEM_ALT_SUB_ALLOC_UNIT_SIZE);
+#else
+    cbReq = RT_ALIGN_32(cbReq + pExecMemAllocator->cbHeapBlockHdr, 64) - pExecMemAllocator->cbHeapBlockHdr;
+#endif
 
     for (unsigned iIteration = 0;; iIteration++)
     {
-        /*
-         * Adjust the request size so it'll fit the allocator alignment/whatnot.
-         *
-         * For the RTHeapSimple allocator this means to follow the logic described
-         * in iemExecMemAllocatorGrow and attempt to allocate it from one of the
-         * existing chunks if we think we've got sufficient free memory around.
-         *
-         * While for the alternative one we just align it up to a whole unit size.
-         */
-#ifdef IEMEXECMEM_USE_ALT_SUB_ALLOCATOR
-        cbReq = RT_ALIGN_32(cbReq, IEMEXECMEM_ALT_SUB_ALLOC_UNIT_SIZE);
-#else
-        cbReq = RT_ALIGN_32(cbReq + pExecMemAllocator->cbHeapBlockHdr, 64) - pExecMemAllocator->cbHeapBlockHdr;
-#endif
         if (cbReq <= pExecMemAllocator->cbFree)
         {
@@ -565 +565 @@
         else
         {
-            /** @todo stats...   */
+            STAM_REL_COUNTER_INC(&pVCpu->iem.s.StatNativeExecMemInstrBufAllocFailed);
             return NULL;
         }

trunk/src/VBox/VMM/VMMR3/IEMR3.cpp

@@ -440 +440 @@
         STAMR3RegisterF(pVM, (void *)&pVCpu->iem.s.StatCheckNeedCsLimChecking, STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_COUNT,
                         "Needing CS.LIM checking TB after branch or on page crossing", "/IEM/CPU%u/re/CheckTbNeedCsLimChecking", idCpu);
+
+        STAMR3RegisterF(pVM, (void *)&pVCpu->iem.s.StatNativeExecMemInstrBufAllocFailed, STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_COUNT,
+                        "Number of times the exec memory allocator failed to allocate a large enough buffer",
+                        "/IEM/CPU%u/re/NativeExecMemInstrBufAllocFailed", idCpu);
 
         STAMR3RegisterF(pVM, (void *)&pVCpu->iem.s.StatNativeCallsRecompiled, STAMTYPE_PROFILE, STAMVISIBILITY_ALWAYS, STAMUNIT_CALLS_PER_TB,

trunk/src/VBox/VMM/include/IEMInternal.h

@@ -1853 +1853 @@
     /** Statistics: Times a jump or page crossing required a TB with CS.LIM checking. */
     STAMCOUNTER             StatCheckNeedCsLimChecking;
+    /** Exec memory allocator statistics: Number of times allocaintg executable memory failed. */
+    STAMCOUNTER             StatNativeExecMemInstrBufAllocFailed;
     /** Native TB statistics: Number of fully recompiled TBs. */
     STAMCOUNTER             StatNativeFullyRecompiledTbs;
@@ -1977 +1979 @@
 #endif
 
-    uint64_t                au64Padding[5];
+    uint64_t                au64Padding[4];
     /** @} */