Changeset 10410 in vbox

Timestamp:

Jul 9, 2008 12:23:26 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

33067

Message:

Introduced VM_FF_REM_HANDLER_NOTIFY action flag to replay the handler notifications whenever possible in ring 3. This will
save some unnecessary context switches.

Location:

trunk

Files:

• include/VBox/vm.h (modified) (2 diffs)
• src/VBox/VMM/VMMAll/REMAll.cpp (modified) (3 diffs)
• src/recompiler/VBoxRecompiler.c (modified) (2 diffs)

trunk/include/VBox/vm.h

@@ -107 +107 @@
 #define VM_FF_TO_R3                     RT_BIT_32(28)
 
+/** REM needs to be informed about handler changes. */
+#define VM_FF_REM_HANDLER_NOTIFY        RT_BIT_32(29)
+
 /** Suspend the VM - debug only. */
 #define VM_FF_DEBUG_SUSPEND             RT_BIT_32(31)
@@ -125 +128 @@
 #define VM_FF_NORMAL_PRIORITY_POST_MASK (VM_FF_TERMINATE | VM_FF_DBGF | VM_FF_RESET | VM_FF_CSAM_SCAN_PAGE)
 /** Normal priority actions. */
-#define VM_FF_NORMAL_PRIORITY_MASK      (VM_FF_REQUEST | VM_FF_PDM_QUEUES | VM_FF_PDM_DMA)
+#define VM_FF_NORMAL_PRIORITY_MASK      (VM_FF_REQUEST | VM_FF_PDM_QUEUES | VM_FF_PDM_DMA | VM_FF_REM_HANDLER_NOTIFY)
 /** Flags to check before resuming guest execution. */
 #define VM_FF_RESUME_GUEST_MASK         (VM_FF_TO_R3)

trunk/src/VBox/VMM/VMMAll/REMAll.cpp

@@ -102 +102 @@
     pRec->u.PhysicalRegister.cb = cb;
     pRec->u.PhysicalRegister.fHasHCHandler = fHasHCHandler;
+    VM_FF_SET(pVM, VM_FF_REM_HANDLER_NOTIFY);
 }
 
@@ -126 +127 @@
     pRec->u.PhysicalDeregister.fHasHCHandler = fHasHCHandler;
     pRec->u.PhysicalDeregister.fRestoreAsRAM = fRestoreAsRAM;
+    VM_FF_SET(pVM, VM_FF_REM_HANDLER_NOTIFY);
 }
 
@@ -152 +154 @@
     pRec->u.PhysicalModify.fHasHCHandler = fHasHCHandler;
     pRec->u.PhysicalModify.fRestoreAsRAM = fRestoreAsRAM;
+    VM_FF_SET(pVM, VM_FF_REM_HANDLER_NOTIFY);
 }
 

trunk/src/recompiler/VBoxRecompiler.c

@@ -2502 +2502 @@
 
 /**
- * Replays the invalidated recorded pages.
- * Called in response to VERR_REM_FLUSHED_PAGES_OVERFLOW from the RAW execution loop.
+ * Replays the handler notification changes
+ * Called in response to VM_FF_REM_HANDLER_NOTIFY from the RAW execution loop.
  *
  * @param   pVM         VM handle.
@@ -2555 +2555 @@
         }
     }
+    VM_FF_CLEAR(pVM, VM_FF_REM_HANDLER_NOTIFY);
 }