Changeset 104100 in vbox for trunk/src

Timestamp:

Mar 28, 2024 2:07:36 AM (10 months ago)

Author:

vboxsync

Message:

VMM/IEM: Optimize kIemTbDbgEntryType_NativeOffset emitting, caching the previous offset instead of searching backwards for it. bugref:10370

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAllN8veRecompiler.cpp (modified) (9 diffs)
• include/IEMInternal.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp

@@ -3236 +3236 @@
 #ifdef IEMNATIVE_WITH_TB_DEBUG_INFO
     pReNative->pDbgInfo->cEntries          = 0;
+    pReNative->pDbgInfo->offNativeLast     = UINT32_MAX;
 #endif
     pReNative->pTbOrg                      = pTb;
@@ -3712 +3713 @@
 
     /*
-     * Search backwards to see if we've got a similar record already.
-     */
-    uint32_t idx     = pDbgInfo->cEntries;
-    uint32_t idxStop = idx > 16 ? idx - 16 : 0;
-    while (idx-- > idxStop)
-        if (pDbgInfo->aEntries[idx].Gen.uType == kIemTbDbgEntryType_NativeOffset)
-        {
-            if (pDbgInfo->aEntries[idx].NativeOffset.offNative == off)
-                return;
-            AssertStmt(pDbgInfo->aEntries[idx].NativeOffset.offNative < off,
-                       IEMNATIVE_DO_LONGJMP(pReNative, VERR_IEM_DBGINFO_IPE_2));
-            break;
-        }
+     * Do we need this one?
+     */
+    uint32_t const offPrev = pDbgInfo->offNativeLast;
+    if (offPrev == off)
+        return;
+    AssertStmt(offPrev < off || offPrev == UINT32_MAX, IEMNATIVE_DO_LONGJMP(pReNative, VERR_IEM_DBGINFO_IPE_2));
 
     /*
@@ -3732 +3726 @@
     pEntry->NativeOffset.uType     = kIemTbDbgEntryType_NativeOffset;
     pEntry->NativeOffset.offNative = off;
+    pDbgInfo->offNativeLast = off;
 }
 
@@ -4790 +4785 @@
             iemNativeDbgInfoAddGuestRegDirty(pReNative, false /*fSimdReg*/, enmGstReg, idxReg);
 # endif
-
             pReNative->Core.bmGstRegShadowDirty |= RT_BIT_64(enmGstReg);
         }
@@ -4823 +4817 @@
         iemNativeDbgInfoAddGuestRegDirty(pReNative, false /*fSimdReg*/, enmGstReg, idxRegNew);
 # endif
-
         pReNative->Core.bmGstRegShadowDirty |= RT_BIT_64(enmGstReg);
     }
@@ -8603 +8596 @@
             iemNativeDbgInfoAddGuestRegDirty(pReNative, false /*fSimdReg*/, enmGstReg, idxReg);
 # endif
-
             pReNative->Core.bmGstRegShadowDirty |= RT_BIT_64(enmGstReg);
         }
@@ -10090 +10082 @@
 #ifdef IEMNATIVE_WITH_DELAYED_PC_UPDATING
                         case kIemTbDbgEntryType_DelayedPcUpdate:
-                            pHlp->pfnPrintf(pHlp,
-                                            "  Updating guest PC value by %u (cInstrSkipped=%u)\n",
+                            pHlp->pfnPrintf(pHlp, "  Updating guest PC value by %u (cInstrSkipped=%u)\n",
                                             pDbgInfo->aEntries[iDbgEntry].DelayedPcUpdate.offPc,
                                             pDbgInfo->aEntries[iDbgEntry].DelayedPcUpdate.cInstrSkipped);
@@ -10101 +10092 @@
                         {
                             PCIEMTBDBGENTRY const pEntry    = &pDbgInfo->aEntries[iDbgEntry];
-                            const char * const    pszGstReg =   pEntry->GuestRegDirty.fSimdReg
-                                                              ? g_aGstSimdShadowInfo[pEntry->GuestRegDirty.idxGstReg].pszName
-                                                              : g_aGstShadowInfo[pEntry->GuestRegDirty.idxGstReg].pszName;
-                            const char * const    pszHstReg =   pEntry->GuestRegDirty.fSimdReg
-                                                              ? g_apszIemNativeHstSimdRegNames[pEntry->GuestRegDirty.idxHstReg]
-                                                              : g_apszIemNativeHstRegNames[pEntry->GuestRegDirty.idxHstReg];
-                            pHlp->pfnPrintf(pHlp,
-                                            "  Guest register %s (shadowed by %s) is now dirty\n",
+                            const char * const    pszGstReg = pEntry->GuestRegDirty.fSimdReg
+                                                            ? g_aGstSimdShadowInfo[pEntry->GuestRegDirty.idxGstReg].pszName
+                                                            : g_aGstShadowInfo[pEntry->GuestRegDirty.idxGstReg].pszName;
+                            const char * const    pszHstReg = pEntry->GuestRegDirty.fSimdReg
+                                                            ? g_apszIemNativeHstSimdRegNames[pEntry->GuestRegDirty.idxHstReg]
+                                                            : g_apszIemNativeHstRegNames[pEntry->GuestRegDirty.idxHstReg];
+                            pHlp->pfnPrintf(pHlp, "  Guest register %s (shadowed by %s) is now marked dirty (intent)\n",
                                             pszGstReg, pszHstReg);
                             continue;
@@ -10114 +10104 @@
 
                         case kIemTbDbgEntryType_GuestRegWriteback:
-                            pHlp->pfnPrintf(pHlp,
-                                            "  Writing dirty %s registers (gst %#RX64)\n",
+                            pHlp->pfnPrintf(pHlp, "  Writing dirty %s registers (gst %#RX32)\n",
                                             pDbgInfo->aEntries[iDbgEntry].GuestRegWriteback.fSimdReg ? "SIMD" : "general",
                                             pDbgInfo->aEntries[iDbgEntry].GuestRegWriteback.fGstReg);

trunk/src/VBox/VMM/include/IEMInternal.h

@@ -1137 +1137 @@
     /** Number of entries in aEntries. */
     uint32_t        cEntries;
+    /** The offset of the last kIemTbDbgEntryType_NativeOffset record. */
+    uint32_t        offNativeLast;
     /** Debug info entries. */
     RT_FLEXIBLE_ARRAY_EXTENSION