Changeset 104110 in vbox

Timestamp:

Mar 28, 2024 10:26:33 PM (10 months ago)

Author:

vboxsync

Message:

VMM/IEM: Removed incorrect cbReq alignment in iemExecMemAllocatorAlloc. The iemExecMemAllocatorAllocInChunk suballocator function does the correct alignment and takes the header into account. bugref:10370

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp

@@ -509 +509 @@
     STAM_PROFILE_START(&pExecMemAllocator->StatAlloc, a);
 
-    /*
-     * Adjust the request size so it'll accomodate a header, the aligned it
-     * up to a whole unit size.
-     */
-/** @todo this aint right wrt header. See iemExecMemAllocatorAllocInChunk   */
-    cbReq = RT_ALIGN_32(cbReq, IEMEXECMEM_ALT_SUB_ALLOC_UNIT_SIZE);
     for (unsigned iIteration = 0;; iIteration++)
     {
@@ -563 +557 @@
          */
         if (iIteration == 0)
-            iemTbAllocatorFreeupNativeSpace(pVCpu, cbReq / sizeof(IEMNATIVEINSTR));
+        {
+            /* No header included in the instruction count here. */
+            uint32_t const cNeededInstrs = RT_ALIGN_32(cbReq, IEMEXECMEM_ALT_SUB_ALLOC_UNIT_SIZE) / sizeof(IEMNATIVEINSTR));
+            iemTbAllocatorFreeupNativeSpace(pVCpu, cNeededInstrs);
+        }
         else
         {