Changeset 104145 in vbox

Timestamp:

Apr 3, 2024 7:32:08 PM (12 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

162567

Message:

VMM/IEM: Correct canonical check on arm64 hosts, wrong shift (both direction and count). The comment was correct, though. Cause a lot of false TLB misses. bugref:10371

File:

• trunk/src/VBox/VMM/include/IEMN8veRecompilerTlbLookup.h (modified) (1 diff)

trunk/src/VBox/VMM/include/IEMN8veRecompilerTlbLookup.h

@@ -566 +566 @@
 # elif defined(RT_ARCH_ARM64)
         /* lsr  reg1, regflat, #48 */
-        pCodeBuf[off++] = Armv8A64MkInstrLslImm(pTlbState->idxReg1, idxRegFlatPtr, 4);
+        pCodeBuf[off++] = Armv8A64MkInstrLsrImm(pTlbState->idxReg1, idxRegFlatPtr, 48);
         /* add  reg1, reg1, #1 */
         pCodeBuf[off++] = Armv8A64MkInstrAddUImm12(pTlbState->idxReg1, pTlbState->idxReg1, 1, false /*f64Bit*/);
         /* tst  reg1, #0xfffe */
         Assert(Armv8A64ConvertImmRImmS2Mask32(14, 31) == 0xfffe);
-        pCodeBuf[off++] = Armv8A64MkInstrTstImm(pTlbState->idxReg1, 14, 31,  false /*f64Bit*/);
+        pCodeBuf[off++] = Armv8A64MkInstrTstImm(pTlbState->idxReg1, 14, 31, false /*f64Bit*/);
         /* b.nq tlbmiss */
         off = iemNativeEmitJccToLabelEx(pReNative, pCodeBuf, off, idxLabelTlbMiss, kIemNativeInstrCond_ne);