Changeset 104174 in vbox for trunk/src/VBox/VMM/include

Timestamp:

Apr 5, 2024 10:21:30 AM (8 months ago)

Author:

vboxsync

Message:

VMM/IEM: Get rid of IEM_MC_REF_MXCSR() and convert the users to use IEM_MC_CALL_SSE_AIMPL_XXX which handles the MXCSR, avoids passing the MXCSR as a reference so the recompiler can use shadowed registers, bugref:10641

Location:

trunk/src/VBox/VMM/include

Files:

• IEMInternal.h (modified) (3 diffs)
• IEMMc.h (modified) (1 diff)

trunk/src/VBox/VMM/include/IEMInternal.h

@@ -3927 +3927 @@
 FNIEMAIMPLMXCSRF2XMMIMM8 iemAImpl_dppd_u128, iemAImpl_dppd_u128_fallback;
 
-typedef IEM_DECL_IMPL_TYPE(void, FNIEMAIMPLMXCSRU64U128,(uint32_t *pfMxcsr, uint64_t *pu64Dst, PCX86XMMREG pSrc));
+typedef IEM_DECL_IMPL_TYPE(uint32_t, FNIEMAIMPLMXCSRU64U128,(uint32_t fMxCsrIn, uint64_t *pu64Dst, PCX86XMMREG pSrc));
 typedef FNIEMAIMPLMXCSRU64U128 *PFNIEMAIMPLMXCSRU64U128;
 
@@ -3933 +3933 @@
 FNIEMAIMPLMXCSRU64U128 iemAImpl_cvttpd2pi_u128;
 
-typedef IEM_DECL_IMPL_TYPE(void, FNIEMAIMPLMXCSRU128U64,(uint32_t *pfMxcsr, PX86XMMREG pDst, uint64_t u64Src));
+typedef IEM_DECL_IMPL_TYPE(uint32_t, FNIEMAIMPLMXCSRU128U64,(uint32_t fMxCsrIn, PX86XMMREG pDst, uint64_t u64Src));
 typedef FNIEMAIMPLMXCSRU128U64 *PFNIEMAIMPLMXCSRU128U64;
 
@@ -3939 +3939 @@
 FNIEMAIMPLMXCSRU128U64 iemAImpl_cvtpi2pd_u128;
 
-typedef IEM_DECL_IMPL_TYPE(void, FNIEMAIMPLMXCSRU64U64,(uint32_t *pfMxcsr, uint64_t *pu64Dst, uint64_t u64Src));
+typedef IEM_DECL_IMPL_TYPE(uint32_t, FNIEMAIMPLMXCSRU64U64,(uint32_t fMxCsrIn, uint64_t *pu64Dst, uint64_t u64Src));
 typedef FNIEMAIMPLMXCSRU64U64 *PFNIEMAIMPLMXCSRU64U64;
 

trunk/src/VBox/VMM/include/IEMMc.h

@@ -329 +329 @@
 #define IEM_MC_REF_EFLAGS(a_pEFlags)                    (a_pEFlags) = &pVCpu->cpum.GstCtx.eflags.uBoth
 #define IEM_MC_REF_EFLAGS_EX(a_pEFlags, a_fEflInput, a_fEflOutput) IEM_MC_REF_EFLAGS(a_pEFlags)
-#define IEM_MC_REF_MXCSR(a_pfMxcsr)                     (a_pfMxcsr) = &pVCpu->cpum.GstCtx.XState.x87.MXCSR
 
 #define IEM_MC_ADD_GREG_U16(a_iGReg, a_u16Value)        *iemGRegRefU16(pVCpu, (a_iGReg)) += (a_u16Value)