Changeset 104208 in vbox for trunk/src/VBox/VMM/VMMAll/IEMAllAImpl.asm

Timestamp:

Apr 5, 2024 9:17:41 PM (8 months ago)

Author:

vboxsync

Message:

VMM/IEM: Refactoring assembly helpers to not pass eflags by reference but instead by value and return the updated value (via eax/w0) - fourth chunk: ARPL, ADCX, ADOX. bugref:10376

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllAImpl.asm (modified) (4 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllAImpl.asm

@@ -6839 +6839 @@
 ; 32-bit forms of ADCX and ADOX
 ;
-; @param    A0      Pointer to the destination operand (input/output).
-; @param    A1      32-bit source operand 1 (input).
-; @param    A2      Pointer to the EFLAGS value (input/output).
+; @returns  Updated EFLAGS.
+; @param    A0      Incoming EFLAGS value (input).
+; @param    A1      Pointer to the destination operand (input/output).
+; @param    A2      32-bit source operand 1 (input).
 ;
 %macro IEMIMPL_ADX_32 2
@@ -6847 +6848 @@
         PROLOGUE_4_ARGS
 
-        IEM_LOAD_FLAGS_OLD A2, %2, 0
-        %1      A1_32, [A0]
-        mov     [A0], A1_32
-        IEM_SAVE_FLAGS_OLD A2, %2, 0, 0
+        IEM_LOAD_FLAGS          A0_32, %2, 0
+        %1      A2_32, [A1]
+        mov     [A1], A2_32
+        IEM_SAVE_FLAGS_RETVAL   A0_32, %2, 0, 0
 
         EPILOGUE_4_ARGS
@@ -6859 +6860 @@
 ; 64-bit forms of ADCX and ADOX
 ;
-; @param    A0      Pointer to the destination operand (input/output).
-; @param    A1      64-bit source operand 1 (input).
-; @param    A2      Pointer to the EFLAGS value (input/output).
+; @returns  Updated EFLAGS.
+; @param    A0      Incoming EFLAGS value (input).
+; @param    A1      Pointer to the destination operand (input/output).
+; @param    A2      64-bit source operand 1 (input).
 ;
 %macro IEMIMPL_ADX_64 2
@@ -6867 +6869 @@
         PROLOGUE_4_ARGS
 
-        IEM_LOAD_FLAGS_OLD A2, %2, 0
-        %1      A1, [A0]
-        mov     [A0], A1
-        IEM_SAVE_FLAGS_OLD A2, %2, 0, 0
+        IEM_LOAD_FLAGS          A0_32, %2, 0
+        %1      A2, [A1]
+        mov     [A1], A2
+        IEM_SAVE_FLAGS_RETVAL   A0_32, %2, 0, 0
 
         EPILOGUE_4_ARGS