Changeset 104250 in vbox

Timestamp:

Apr 9, 2024 11:55:04 AM (11 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

162703

Message:

DevOHCI: Take more care when adding items to in-flight tracker (see bugref:10612).

File:

• trunk/src/VBox/Devices/USB/DevOHCI.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/USB/DevOHCI.cpp

@@ -911 +911 @@
 static DECLCALLBACK(bool)   ohciR3RhXferError(PVUSBIROOTHUBPORT pInterface, PVUSBURB pUrb);
 
+static bool                 ohciR3IsTdInFlight(POHCICC pThisCC, uint32_t GCPhysTD);
 static int                  ohciR3InFlightFind(POHCICC pThisCC, uint32_t GCPhysTD);
 # if defined(VBOX_STRICT) || defined(LOG_ENABLED)
@@ -1942 +1943 @@
 static void ohciR3InFlightAdd(POHCI pThis, POHCICC pThisCC, uint32_t GCPhysTD, PVUSBURB pUrb)
 {
+    if (ohciR3IsTdInFlight(pThisCC, GCPhysTD))
+    {
+        PPDMDEVINS pDevIns = pThisCC->pDevInsR3;
+        ohciR3RaiseUnrecoverableError(pDevIns, pThis, 10);
+        return;
+    }
+
     int i = ohciR3InFlightFindFree(pThisCC, (GCPhysTD >> 4) % RT_ELEMENTS(pThisCC->aInFlight));
     if (i >= 0)