Changeset 104280 in vbox for trunk/src/VBox/Devices/USB

Timestamp:

Apr 10, 2024 4:48:47 PM (8 months ago)

Author:

vboxsync

Message:

VirtioCore: improved chain length checks and MMIO read handling in PciIch0 and PCNet, as well as input context initialization in XHCI. bugref:10635

File:

• trunk/src/VBox/Devices/USB/DevXHCI.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/USB/DevXHCI.cpp

@@ -4564 +4564 @@
     unsigned        uDCI;
 
+    RT_ZERO(dc_inp);
+
     Assert(uSlotID);
     LogFlowFunc(("Slot ID %u, input control context @ %RGp\n", uSlotID, GCPhysInpCtx));
@@ -4645 +4647 @@
             /// @todo Check input EP contexts according to 6.2.3.2
         }
-/** @todo r=bird: Looks like MSC is right that dc_inp can be used uninitalized.
- *
- * However, this function is so hard to read I'm leaving the exorcism of it to
- * the author and just zeroing it in the mean time.
- *
- */
-        else
-            RT_ZERO(dc_inp);
-
         /* Read the output Slot Context plus all Endpoint Contexts up to and
          * including the one with the highest 'add' or 'drop' bit set.