Changeset 104283 in vbox

Timestamp:

Apr 10, 2024 5:46:25 PM (10 months ago)

Author:

vboxsync

Message:

VMM/IEM: Gather statistics on the exit behavior of native TBs, bugref:10653 [redo, can't allocate the temp registers before the loop because the result be IEMNATIVE_CALL_ARG0_GREG which gets clobbered shortly after]

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp (modified) (7 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp

@@ -6195 +6195 @@
     return off;
 }
+
+
+/**
+ * Emits code to update the TB exit reason statistics.
+ */
+DECL_INLINE_THROW(uint32_t)
+iemNativeEmitNativeTbExitStats(PIEMRECOMPILERSTATE pReNative, uint32_t off, uint32_t const offVCpu)
+{
+    uint8_t const idxStatsTmp1 = iemNativeRegAllocTmp(pReNative, &off);
+    uint8_t const idxStatsTmp2 = iemNativeRegAllocTmp(pReNative, &off);
+    off = iemNativeEmitIncStamCounterInVCpu(pReNative, off, idxStatsTmp1, idxStatsTmp2, offVCpu);
+    iemNativeRegFreeTmp(pReNative, idxStatsTmp1);
+    iemNativeRegFreeTmp(pReNative, idxStatsTmp2);
+
+    return off;
+}
 #endif /* VBOX_WITH_STATISTICS */
 
@@ -6210 +6226 @@
 
 #ifdef VBOX_WITH_STATISTICS
-        uint8_t const idxStatsTmp1 = iemNativeRegAllocTmp(pReNative, &off);
-        uint8_t const idxStatsTmp2 = iemNativeRegAllocTmp(pReNative, &off);
-        off = iemNativeEmitIncStamCounterInVCpu(pReNative, off, idxStatsTmp1, idxStatsTmp2,
-                                                RT_UOFFSETOF(VMCPUCC, iem.s.StatNativeTbExitReturnWithFlags));
-        iemNativeRegFreeTmp(pReNative, idxStatsTmp1);
-        iemNativeRegFreeTmp(pReNative, idxStatsTmp2);
+        off = iemNativeEmitNativeTbExitStats(pReNative, off, RT_UOFFSETOF(VMCPUCC, iem.s.StatNativeTbExitReturnWithFlags));
 #endif
 
@@ -6238 +6249 @@
 
 #ifdef VBOX_WITH_STATISTICS
-        uint8_t const idxStatsTmp1 = iemNativeRegAllocTmp(pReNative, &off);
-        uint8_t const idxStatsTmp2 = iemNativeRegAllocTmp(pReNative, &off);
-        off = iemNativeEmitIncStamCounterInVCpu(pReNative, off, idxStatsTmp1, idxStatsTmp2,
-                                                RT_UOFFSETOF(VMCPUCC, iem.s.StatNativeTbExitReturnBreak));
-        iemNativeRegFreeTmp(pReNative, idxStatsTmp1);
-        iemNativeRegFreeTmp(pReNative, idxStatsTmp2);
+        off = iemNativeEmitNativeTbExitStats(pReNative, off, RT_UOFFSETOF(VMCPUCC, iem.s.StatNativeTbExitReturnBreak));
 #endif
 
@@ -9233 +9239 @@
 
 #ifdef VBOX_WITH_STATISTICS
-        {
-            uint8_t const idxStatsTmp1 = iemNativeRegAllocTmp(pReNative, &off);
-            uint8_t const idxStatsTmp2 = iemNativeRegAllocTmp(pReNative, &off);
-            off = iemNativeEmitIncStamCounterInVCpu(pReNative, off, idxStatsTmp1, idxStatsTmp2,
-                                                    RT_UOFFSETOF(VMCPUCC, iem.s.StatNativeTbFinished));
-            iemNativeRegFreeTmp(pReNative, idxStatsTmp1);
-            iemNativeRegFreeTmp(pReNative, idxStatsTmp2);
-        }
+        off = iemNativeEmitNativeTbExitStats(pReNative, off, RT_UOFFSETOF(VMCPUCC, iem.s.StatNativeTbFinished));
 #endif
 
@@ -9291 +9290 @@
         if (fTailLabels)
         {
-#ifdef VBOX_WITH_STATISTICS
-            uint8_t const idxStatsTmp1 = iemNativeRegAllocTmp(pReNative, &off);
-            uint8_t const idxStatsTmp2 = iemNativeRegAllocTmp(pReNative, &off);
-#endif
-
             do
             {
@@ -9309 +9303 @@
 
 #ifdef VBOX_WITH_STATISTICS
-                    off = iemNativeEmitIncStamCounterInVCpu(pReNative, off, idxStatsTmp1, idxStatsTmp2,
-                                                            g_aSimpleTailLabels[enmLabel].offVCpuStats);
+                    off = iemNativeEmitNativeTbExitStats(pReNative, off, g_aSimpleTailLabels[enmLabel].offVCpuStats);
 #endif
 
@@ -9322 +9315 @@
 
             } while (fTailLabels);
-
-#ifdef VBOX_WITH_STATISTICS
-            iemNativeRegFreeTmp(pReNative, idxStatsTmp1);
-            iemNativeRegFreeTmp(pReNative, idxStatsTmp2);
-#endif
         }
     }