Changeset 104284 in vbox

Timestamp:

Apr 11, 2024 12:04:48 AM (8 months ago)

Author:

vboxsync

Message:

IPRT: Reimplemented RTFileDelete for windows to eliminate type checking race and prevent it from accidentally deleting directories. bugref:10632

Location:

trunk/src/VBox/Runtime

Files:

• Makefile.kmk (modified) (2 diffs)
• r3/nt/RTFileDelete-r3-nt.cpp (added)
• r3/win/fileio-win.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/Makefile.kmk

@@ -1047 +1047 @@
         r3/nt/fs-nt.cpp \
         r3/nt/pathint-nt.cpp \
+        r3/nt/RTFileDelete-r3-nt.cpp \
         r3/nt/RTFileQueryFsSizes-nt.cpp \
         r3/nt/RTFileSetMode-r3-nt.cpp \
@@ -2647 +2648 @@
         r3/nt/fs-nt.cpp \
         r3/nt/pathint-nt.cpp \
+        r3/nt/RTFileDelete-r3-nt.cpp \
         r3/nt/RTFileQueryFsSizes-nt.cpp \
         r3/nt/RTFileSetMode-r3-nt.cpp \

trunk/src/VBox/Runtime/r3/win/fileio-win.cpp

@@ -1486 +1486 @@
 /* RTFileQueryFsSizes is implemented by ../nt/RTFileQueryFsSizes-nt.cpp */
 
-
+#if 0 /* RTFileDelete is implemented by ../nt/RTFileDelete-r3-nt.cpp */
 RTR3DECL(int)  RTFileDelete(const char *pszFilename)
 {
@@ -1500 +1500 @@
     return rc;
 }
+#endif