Changeset 104289 in vbox for trunk/src

Timestamp:

Apr 11, 2024 9:11:31 AM (9 months ago)

Author:

vboxsync

Message:

DevLpc: Use IOMMMIO_FLAGS_WRITE_DWORD since we don't really do anything with the writes anyway.

File:

• trunk/src/VBox/Devices/PC/DevLpc.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/PC/DevLpc.cpp

@@ -118 +118 @@
 {
     PLPCSTATE        pThis  = PDMDEVINS_2_DATA(pDevIns, PLPCSTATE);
-    RT_NOREF(pvUser, pv);
-
-    if (cb == 4)
-    {
-        if (off == LPC_REG_GCS)
-            Log(("lpcMmioWrite: Ignorning write to GCS: %.*Rhxs\n", cb, pv));
-        else
-            Log(("lpcMmioWrite: Ignorning write to unknown register %#RGp: %.*Rhxs\n", off, cb, pv));
-    }
+    RT_NOREF(pvUser, pv, cb);
+    Assert(cb == 4); Assert(!(off & 3)); /* IOMMMIO_FLAGS_WRITE_DWORD_xxx should make sure of this */
+
+    if (off == LPC_REG_GCS)
+        Log(("lpcMmioWrite: Ignorning write to GCS: %.*Rhxs\n", cb, pv));
     else
-        Log(("lpcMmioWrite: WARNING! Ignoring non-DWORD write to off=%#RGp: %.*Rhxs\n", off, cb, pv));
+        Log(("lpcMmioWrite: Ignorning write to unknown register %#RGp: %.*Rhxs\n", off, cb, pv));
 
     STAM_REL_COUNTER_INC(&pThis->StatMmioWrites);
@@ -358 +354 @@
      *        mentioned above we just want this working. */
     rc = PDMDevHlpMmioCreateAndMap(pDevIns, pThis->GCPhys32Rcba, 0x4000, lpcMmioWrite, lpcMmioRead,
-                                   IOMMMIO_FLAGS_READ_DWORD | IOMMMIO_FLAGS_WRITE_PASSTHRU,
+                                   IOMMMIO_FLAGS_READ_DWORD | IOMMMIO_FLAGS_WRITE_DWORD_ZEROED,
                                    "LPC Memory", &pThis->hMmio);
     AssertRCReturn(rc, rc);