Changeset 104432 in vbox

Timestamp:

Apr 25, 2024 2:04:47 PM (9 months ago)

Author:

vboxsync

Message:

Virtio/Core: Fixes and descriptor table printing for our debugger's 'info virtionet' bugref:10572 jiraref:VBP-575

Location:

trunk/src/VBox/Devices

Files:

• Network/DevVirtioNet.cpp (modified) (3 diffs)
• VirtIO/VirtioCore.cpp (modified) (7 diffs)

trunk/src/VBox/Devices/Network/DevVirtioNet.cpp

@@ -905 +905 @@
         pHlp->pfnPrintf(pHlp, "    cVirtqs .,................. %d\n",   pThis->cVirtqs);
         pHlp->pfnPrintf(pHlp, "    cWorkers .................. %d\n",   pThis->cWorkers);
-        pHlp->pfnPrintf(pHlp, "    MMIO mapping name ......... %d\n",   pThisCC->Virtio.szMmioName);
+        pHlp->pfnPrintf(pHlp, "    MMIO mapping name ......... %s\n",   pThisCC->Virtio.szMmioName);
         pHlp->pfnPrintf(pHlp, "\n");
     }
@@ -924 +924 @@
         pHlp->pfnPrintf(pHlp, "    Promiscuous: .............. %s\n",      pThis->fPromiscuous   ? "true" : "false");
         pHlp->pfnPrintf(pHlp, "\n");
-        pHlp->pfnPrintf(pHlp, "    Default Rx MAC filter: .... %RTmac\n", pThis->rxFilterMacDefault);
+        pHlp->pfnPrintf(pHlp, "    Default Rx MAC filter: .... %RTmac\n", &pThis->rxFilterMacDefault);
         pHlp->pfnPrintf(pHlp, "\n");
 
@@ -3636 +3636 @@
      */
     char szTmp[128];
-    rc = PDMDevHlpDBGFInfoRegister(pDevIns, "virtio-net", "Display virtio-net info (help, net, features, state, pointers, queues, all)", virtioNetR3Info);
+    rc = PDMDevHlpDBGFInfoRegister(pDevIns, "virtionet", "Display virtionet info (help, net, features, state, pointers, queues, all)", virtioNetR3Info);
     if (RT_FAILURE(rc))
         LogRel(("Failed to register DBGF info for device %s\n", szTmp));

trunk/src/VBox/Devices/VirtIO/VirtioCore.cpp

@@ -619 +619 @@
 }
 
+DECLINLINE(void) virtioCoreR3DescInfo(PCDBGFINFOHLP pHlp, PVIRTQ_DESC_T pDesc, uint16_t iDesc, const char *cszTail)
+{
+    if (pDesc->fFlags & VIRTQ_DESC_F_NEXT)
+        pHlp->pfnPrintf(pHlp, "          [%4d]%c%c %5d bytes @ %p  [%4d] %s\n",
+                        iDesc, pDesc->fFlags & VIRTQ_DESC_F_INDIRECT ? 'I' : ' ',
+                        pDesc->fFlags & VIRTQ_DESC_F_WRITE ? 'W' : 'R',
+                        pDesc->cb, pDesc->GCPhysBuf, pDesc->uDescIdxNext, cszTail);
+    else
+        pHlp->pfnPrintf(pHlp, "          [%4d]%c%c %5d bytes @ %p         %s\n",
+                        iDesc, pDesc->fFlags & VIRTQ_DESC_F_INDIRECT ? 'I' : ' ',
+                        pDesc->fFlags & VIRTQ_DESC_F_WRITE ? 'W' : 'R',
+                        pDesc->cb, pDesc->GCPhysBuf, cszTail);
+}
+
 /** API Fuunction: See header file */
 DECLHIDDEN(void) virtioCoreR3VirtqInfo(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs, int uVirtq)
@@ -635 +649 @@
     uint16_t uUsedIdxShadow  = pVirtq->uUsedIdxShadow;
 
+    uint16_t uAvailEventIdx = 0;
+    uint16_t uUsedEventIdx = 0;
+    bool     fNotify = !!(pVirtio->uDriverFeatures & VIRTIO_F_EVENT_IDX);
+    if (fNotify)
+    {
+        uUsedEventIdx = virtioReadAvailUsedEvent(pDevIns, pVirtio, pVirtq);
+        /* There is no helper for reading AvailEvent since the device is not supposed to read it. */
+        virtioCoreGCPhysRead(pVirtio, pDevIns,
+                            pVirtq->GCPhysVirtqUsed
+                            + RT_UOFFSETOF_DYN(VIRTQ_USED_T, aRing[pVirtq->uQueueSize]),
+                            &uAvailEventIdx, sizeof(uAvailEventIdx));
+    }
+
     VIRTQBUF_T VirtqBuf;
     PVIRTQBUF pVirtqBuf = &VirtqBuf;
+    RT_ZERO(VirtqBuf);  /* Make sure pSgPhysSend and pSgPhysReturn are initialized. */
     bool fEmpty = IS_VIRTQ_EMPTY(pDevIns, pVirtio, pVirtq);
 
@@ -659 +687 @@
     pHlp->pfnPrintf(pHlp, "\n");
     pHlp->pfnPrintf(pHlp, "       avail ring (%d entries):\n", uAvailIdx - uAvailIdxShadow);
-    pHlp->pfnPrintf(pHlp, "          index: ................ %d\n", uAvailIdx);
-    pHlp->pfnPrintf(pHlp, "          shadow: ............... %d\n", uAvailIdxShadow);
+    pHlp->pfnPrintf(pHlp, "          index: ................ %d (%d)\n", pVirtq->uQueueSize ? uAvailIdx % pVirtq->uQueueSize : uAvailIdx, uAvailIdx);
+    pHlp->pfnPrintf(pHlp, "          shadow: ............... %d (%d)\n", pVirtq->uQueueSize ? uAvailIdxShadow % pVirtq->uQueueSize : uAvailIdxShadow, uAvailIdxShadow);
     pHlp->pfnPrintf(pHlp, "          flags: ................ %s\n", fAvailNoInterrupt ? "NO_INTERRUPT" : "");
     pHlp->pfnPrintf(pHlp, "\n");
-    pHlp->pfnPrintf(pHlp, "       used ring (%d entries):\n",  uUsedIdx - uUsedIdxShadow);
-    pHlp->pfnPrintf(pHlp, "          index: ................ %d\n", uUsedIdx);
-    pHlp->pfnPrintf(pHlp, "          shadow: ............... %d\n", uUsedIdxShadow);
+    pHlp->pfnPrintf(pHlp, "       used ring (%d entries):\n",  uUsedIdxShadow - uUsedIdx);
+    pHlp->pfnPrintf(pHlp, "          index: ................ %d (%d)\n", pVirtq->uQueueSize ? uUsedIdx % pVirtq->uQueueSize : uUsedIdx, uUsedIdx);
+    pHlp->pfnPrintf(pHlp, "          shadow: ............... %d (%d)\n", pVirtq->uQueueSize ? uUsedIdxShadow % pVirtq->uQueueSize : uUsedIdxShadow, uUsedIdxShadow);
     pHlp->pfnPrintf(pHlp, "          flags: ................ %s\n", fUsedNoNotify ? "NO_NOTIFY" : "");
     pHlp->pfnPrintf(pHlp, "\n");
@@ -671 +699 @@
     {
         pHlp->pfnPrintf(pHlp, "       desc chain:\n");
-        pHlp->pfnPrintf(pHlp, "          head idx: ............. %d\n", uUsedIdx);
+        pHlp->pfnPrintf(pHlp, "          head idx: ............. %d (%d)\n", pVirtq->uQueueSize ? uUsedIdx % pVirtq->uQueueSize : uUsedIdx, uUsedIdx);
         pHlp->pfnPrintf(pHlp, "          segs: ................. %d\n", cSendSegs + cReturnSegs);
         pHlp->pfnPrintf(pHlp, "          refCnt ................ %d\n", pVirtqBuf->cRefs);
@@ -683 +711 @@
         }
         pHlp->pfnPrintf(pHlp, "\n");
-        pHlp->pfnPrintf(pHlp,     "      guest-to-host (%d bytes)\n",       pVirtqBuf->cbPhysReturn);
+        pHlp->pfnPrintf(pHlp,     "          guest-to-host (%d bytes):\n",  pVirtqBuf->cbPhysReturn);
         pHlp->pfnPrintf(pHlp,     "             segs: .............. %d\n", cReturnSegs);
         if (cReturnSegs)
@@ -691 +719 @@
         }
     } else
-        pHlp->pfnPrintf(pHlp,     "      No desc chains available\n");
+        pHlp->pfnPrintf(pHlp,     "       no desc chains available\n");
     pHlp->pfnPrintf(pHlp, "\n");
+
+    /* Avoid handling zero-sized queues, there is nothing to show anyway. */
+    if (pVirtq->uQueueSize == 0)
+        return;
+
+    pHlp->pfnPrintf(pHlp, "       desc table:\n");
+    /*
+     * Each line in the descriptor table output consists of two parts: a fixed part and a variable "tail".
+     * The fixed part shows the descriptor index, its writability, size, physical address, and optionally
+     * which descriptor is next the chain. The tail shows which elements of avail/used rings point to
+     * this descriptor.
+     */
+    VIRTQ_DESC_T descTable[VIRTQ_SIZE];
+    char aszTails[VIRTQ_SIZE][32];
+    virtioCoreGCPhysRead(pVirtio, pDevIns, pVirtq->GCPhysVirtqDesc,
+                        &descTable, sizeof(VIRTQ_DESC_T) * pVirtq->uQueueSize);
+    RT_BZERO(aszTails, sizeof(aszTails));   /* No tails by default */
+
+    /* Fill avail tail fields. */
+
+    /* The first available descriptor gets outer reverse angle brackets. */
+    char chOuterLeft = '>', chOuterRight = '<';
+    char chLeft = '[', chRight = ']';
+    /* Use 'not-equal' instead of 'less' because of uint16_t wrapping! */
+    for (uint16_t i = uAvailIdxShadow; i != uAvailIdx; i++)
+    {
+        /* The last descriptor gets inner curly braces, inner square brackets for the rest. */
+        if (i + 1 == uAvailIdx) { chLeft = '{'; chRight = '}'; }
+        uint16_t uDescIdx = virtioReadAvailDescIdx(pDevIns, pVirtio, pVirtq, i);
+        /* Print an exclamation sign instead of outer right bracket if this descriptor triggers notification. */
+        RTStrPrintf(aszTails[uDescIdx], sizeof(aszTails[0]), "%c%c%4d%c%c ",
+                    chOuterLeft, chLeft, i % pVirtq->uQueueSize, chRight,
+                    fNotify ? ((i % pVirtq->uQueueSize) == (uAvailEventIdx % pVirtq->uQueueSize) ? '!' : chOuterRight) : chOuterRight);
+        chOuterLeft = chOuterRight = ' ';
+    }
+
+    /* Fill used tail fields, see comments in the similar loop above. */
+
+    chOuterLeft = '>'; chOuterRight = '<';
+    chLeft = '['; chRight = ']';
+    for (uint16_t i = uUsedIdx; i != uUsedIdxShadow; i++)
+    {
+        VIRTQ_USED_ELEM_T elem;
+        virtioCoreGCPhysRead(pVirtio, pDevIns,
+                             pVirtq->GCPhysVirtqUsed
+                             + RT_UOFFSETOF_DYN(VIRTQ_USED_T, aRing[i % pVirtq->uQueueSize]),
+                             &elem, sizeof(elem));
+        if (i + 1 == uUsedIdxShadow) { chLeft = '{'; chRight = '}'; }
+        char *szTail = aszTails[elem.uDescIdx % pVirtq->uQueueSize];
+        /* Add empty avail field if none is present, 9 spaces + terminating zero. */
+        if (*szTail == '\0')
+            RTStrCopy(szTail, 10, "          ");
+        RTStrPrintf(szTail + 9, sizeof(aszTails[0]) - 9, " %c%c%4d%c%c %d bytes",
+                    chOuterLeft, chLeft, i % pVirtq->uQueueSize, chRight,
+                    fNotify ? ((i % pVirtq->uQueueSize) == (uUsedEventIdx % pVirtq->uQueueSize) ? '!' : chOuterRight) : chOuterRight,
+                    elem.cbElem);
+        chOuterLeft = chOuterRight = ' ';
+    }
+
+    pHlp->pfnPrintf(pHlp, "          index w/r size         phys addr        next    @avail   @used\n");
+    pHlp->pfnPrintf(pHlp, "          ------ - -----------   ---------------- ------- -------- ------------------\n");
+    for (uint16_t i = 0; i < pVirtq->uQueueSize; i++)
+        virtioCoreR3DescInfo(pHlp, &descTable[i], i, aszTails[i]);
 }
 
@@ -857 +948 @@
             if (ASMAtomicIncU32(&s_cMessages) == ASMAtomicReadU32(&s_cThreshold))
             {
-                LogRelMax(64, ("Too many linked descriptors; check if the guest arranges descriptors in a loop (cSegsIn=%u cSegsOut=%u uQueueSize=%u).\n",
-                               cSegsIn, cSegsOut, pVirtq->uQueueSize));
+                LogRelMax(64, ("Too many linked descriptors; check if the guest arranges descriptors in a loop (cSegsIn=%u cSegsOut=%u uQueueSize=%u uDescIdx=%u queue=%s).\n",
+                               cSegsIn, cSegsOut, pVirtq->uQueueSize, uDescIdx, pVirtq->szName));
                 if (ASMAtomicReadU32(&s_cMessages) != 1)
                     LogRelMax(64, ("(the above error has occured %u times so far)\n", ASMAtomicReadU32(&s_cMessages)));