Changeset 104484 in vbox

Timestamp:

May 2, 2024 4:27:40 PM (7 months ago)

Author:

vboxsync

Message:

libs/xpcom/ipc: Convert an AssertReturn() to AssertRelease() to silence parfait. This really shouldn't happen and if it would in a release build the caller would most likely cause a NULL pointer access when accessing the payload because it assumes a non NULL pointer. So we can already crash here instead of in the caller bugref:3409

File:

• trunk/src/libs/xpcom18a4/ipc/ipcd/shared/src/ipcMessageNew.h (modified) (1 diff)

trunk/src/libs/xpcom18a4/ipc/ipcd/shared/src/ipcMessageNew.h

@@ -296 +296 @@
 DECLINLINE(void *) IPCMsgGetPayload(PCIPCMSG pThis)
 {
-    AssertReturn(pThis->pMsgHdr, NULL);
+    AssertRelease(pThis->pMsgHdr);
 
     return pThis->pMsgHdr + 1;