Changeset 104567 in vbox

Timestamp:

May 8, 2024 4:46:37 PM (7 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10671: Accessibility fixes for Add Cloud VM wizard; Switching from QListWidget to own QIListWidget, using proper what's this for the list.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/wizards/addcloudvm

Files:

• UIWizardAddCloudVMPageExpert.cpp (modified) (5 diffs)
• UIWizardAddCloudVMPageExpert.h (modified) (2 diffs)
• UIWizardAddCloudVMPageSource.cpp (modified) (8 diffs)
• UIWizardAddCloudVMPageSource.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/wizards/addcloudvm/UIWizardAddCloudVMPageExpert.cpp

@@ -31 +31 @@
 #include <QHeaderView>
 #include <QLabel>
-#include <QListWidget>
 #include <QPushButton>
 #include <QTableWidget>
@@ -38 +37 @@
 /* GUI includes: */
 #include "QIComboBox.h"
+#include "QIListWidget.h"
 #include "QIToolButton.h"
 #include "UICloudNetworkingStuff.h"
@@ -154 +154 @@
 
                     /* Prepare source instances table: */
-                    m_pSourceInstanceList = new QListWidget(pWidgetSource);
+                    m_pSourceInstanceList = new QIListWidget(pWidgetSource);
                     if (m_pSourceInstanceList)
                     {
@@ -187 +187 @@
     connect(m_pProfileToolButton, &QIToolButton::clicked,
             this, &UIWizardAddCloudVMPageExpert::sltHandleProfileButtonClick);
-    connect(m_pSourceInstanceList, &QListWidget::itemSelectionChanged,
+    connect(m_pSourceInstanceList, &QIListWidget::itemSelectionChanged,
             this, &UIWizardAddCloudVMPageExpert::sltHandleSourceInstanceChange);
 }
@@ -227 +227 @@
         m_pProfileToolButton->setToolTip(UIWizardAddCloudVM::tr("Opens cloud profile manager..."));
     }
+
+    /* Translate source stuff: */
+    m_pSourceInstanceList->setWhatsThis(UIWizardAddCloudVM::tr("Lists all the cloud VM instances."));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/addcloudvm/UIWizardAddCloudVMPageExpert.h

@@ -38 +38 @@
 class QGridLayout;
 class QLabel;
+class QIListWidget;
 class UIToolBox;
 class UIWizardAddCloudVM;
@@ -103 +104 @@
     QLabel       *m_pSourceInstanceLabel;
     /** Holds the source instance list instance. */
-    QListWidget  *m_pSourceInstanceList;
+    QIListWidget *m_pSourceInstanceList;
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/addcloudvm/UIWizardAddCloudVMPageSource.cpp

@@ -30 +30 @@
 #include <QHeaderView>
 #include <QLabel>
-#include <QListWidget>
 #include <QPushButton>
 #include <QVBoxLayout>
@@ -36 +35 @@
 /* GUI includes: */
 #include "QIComboBox.h"
+#include "QIListWidget.h"
 #include "QIRichTextLabel.h"
 #include "QIToolButton.h"
@@ -197 +197 @@
 }
 
-void UIWizardAddCloudVMSource::populateProfileInstances(QListWidget *pList, UINotificationCenter *pCenter, const CCloudClient &comClient)
+void UIWizardAddCloudVMSource::populateProfileInstances(QIListWidget *pList, UINotificationCenter *pCenter, const CCloudClient &comClient)
 {
     /* Sanity check: */
@@ -220 +220 @@
         {
             /* Create list item: */
-            QListWidgetItem *pItem = new QListWidgetItem(names.at(i), pList);
+            QIListWidgetItem *pItem = new QIListWidgetItem(names.at(i), pList);
             if (pItem)
             {
@@ -237 +237 @@
 }
 
-QStringList UIWizardAddCloudVMSource::currentListWidgetData(QListWidget *pList)
+QStringList UIWizardAddCloudVMSource::currentListWidgetData(QIListWidget *pList)
 {
     QStringList result;
-    foreach (QListWidgetItem *pItem, pList->selectedItems())
+    foreach (QIListWidgetItem *pItem, pList->selectedItems())
         result << pItem->data(Qt::UserRole).toString();
     return result;
@@ -350 +350 @@
 
             /* Prepare source instances table: */
-            m_pSourceInstanceList = new QListWidget(this);
+            m_pSourceInstanceList = new QIListWidget(this);
             if (m_pSourceInstanceList)
             {
@@ -391 +391 @@
     connect(m_pProfileToolButton, &QIToolButton::clicked,
             this, &UIWizardAddCloudVMPageSource::sltHandleProfileButtonClick);
-    connect(m_pSourceInstanceList, &QListWidget::itemSelectionChanged,
+    connect(m_pSourceInstanceList, &QIListWidget::itemSelectionChanged,
             this, &UIWizardAddCloudVMPageSource::sltHandleSourceInstanceChange);
 }
@@ -435 +435 @@
         m_pProfileToolButton->setToolTip(UIWizardAddCloudVM::tr("Opens cloud profile manager..."));
     }
+
+    /* Translate source stuff: */
     m_pSourceInstanceLabel->setText(UIWizardAddCloudVM::tr("&Instances:"));
+    m_pSourceInstanceList->setWhatsThis(UIWizardAddCloudVM::tr("Lists all the cloud VM instances."));
 
     /* Adjust label widths: */

trunk/src/VBox/Frontends/VirtualBox/src/wizards/addcloudvm/UIWizardAddCloudVMPageSource.h

@@ -41 +41 @@
 class QGridLayout;
 class QLabel;
-class QListWidget;
 class QIComboBox;
+class QIListWidget;
 class QIRichTextLabel;
 class QIToolButton;
@@ -71 +71 @@
     void populateProfiles(QIComboBox *pCombo, UINotificationCenter *pCenter, const QString &strProviderShortName, const QString &strProfileName);
     /** Populates @a pList with profile instances available in @a comClient. */
-    void populateProfileInstances(QListWidget *pList, UINotificationCenter *pCenter, const CCloudClient &comClient);
+    void populateProfileInstances(QIListWidget *pList, UINotificationCenter *pCenter, const CCloudClient &comClient);
 
     /** Returns current user data for @a pList specified. */
-    QStringList currentListWidgetData(QListWidget *pList);
+    QStringList currentListWidgetData(QIListWidget *pList);
 }
 
@@ -144 +144 @@
     QLabel       *m_pSourceInstanceLabel;
     /** Holds the source instance list instance. */
-    QListWidget  *m_pSourceInstanceList;
+    QIListWidget *m_pSourceInstanceList;
 };