Changeset 104604 in vbox for trunk/src/VBox/Devices/USB

Timestamp:

May 13, 2024 3:20:33 PM (7 months ago)

Author:

vboxsync

Message:

Devices/USB/DevOHCI.cpp: Fix parfait warning about unused chg variable which is only used in LOG_ENABLED builds, bugref:3409

File:

• trunk/src/VBox/Devices/USB/DevOHCI.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/USB/DevOHCI.cpp

@@ -5303 +5303 @@
     POHCICC pThisCC = PDMDEVINS_2_DATA_CC(pDevIns, POHCICC);
 
+#ifdef LOG_ENABLED
     /* log */
     uint32_t old = pThis->RootHub.status;
-    uint32_t chg;
     if (val & ~0x80038003)
         Log2(("HcRhStatus_w: Unknown bits %#x are set!!!\n", val & ~0x80038003));
@@ -5312 +5312 @@
     if ( (val & OHCI_RHS_DRWE) && (val & OHCI_RHS_CRWE) )
         Log2(("HcRhStatus_w: Warning both CRWE and SRWE are set! (Clear/Set Remote Wakeup Enable)\n"));
-
+#endif
 
     /* write 1 to clear OCIC */
@@ -5342 +5342 @@
         pThis->RootHub.status &= ~OHCI_RHS_DRWE;
 
-    chg = pThis->RootHub.status ^ old;
+#ifdef LOG_ENABLED
+    uint32_t chg = pThis->RootHub.status ^ old;
     Log2(("HcRhStatus_w(%#010x) => %sCGP=%d %sOCI=%d %sSRWE=%d %sSGP=%d %sOCIC=%d %sCRWE=%d\n",
           val,
@@ -5351 +5352 @@
           (chg >> 17) & 1 ? "*" : "", (val >> 17) & 1,
           (chg >> 31) & 1 ? "*" : "", (val >> 31) & 1));
+#endif
     RT_NOREF(pDevIns, iReg);
     return VINF_SUCCESS;