Changeset 104613 in vbox

Timestamp:

May 13, 2024 4:10:34 PM (11 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

163155

Message:

Debugger/DBGCGdbRemoteStub.cpp: Error handling fixes, bugref:3409

File:

• trunk/src/VBox/Debugger/DBGCGdbRemoteStub.cpp (modified) (2 diffs)

trunk/src/VBox/Debugger/DBGCGdbRemoteStub.cpp

@@ -2522 +2522 @@
                     else
                         rc = pDbgc->CmdHlp.pfnPrintf(&pDbgc->CmdHlp, NULL, "\ndbgf event: %s!", pEvtDesc->pszName);
-                    if (pEvent->u.Generic.cArgs <= 1)
-                        rc = pDbgc->CmdHlp.pfnPrintf(&pDbgc->CmdHlp, NULL, " arg=%#llx\n", pEvent->u.Generic.auArgs[0]);
-                    else
+                    if (RT_SUCCESS(rc))
                     {
-                        for (uint32_t i = 0; i < pEvent->u.Generic.cArgs; i++)
-                            rc = pDbgc->CmdHlp.pfnPrintf(&pDbgc->CmdHlp, NULL, " args[%u]=%#llx", i, pEvent->u.Generic.auArgs[i]);
-                        rc = pDbgc->CmdHlp.pfnPrintf(&pDbgc->CmdHlp, NULL, "\n");
+                        if (pEvent->u.Generic.cArgs <= 1)
+                            rc = pDbgc->CmdHlp.pfnPrintf(&pDbgc->CmdHlp, NULL, " arg=%#llx\n", pEvent->u.Generic.auArgs[0]);
+                        else
+                        {
+                            for (uint32_t i = 0; i < pEvent->u.Generic.cArgs; i++)
+                                rc = pDbgc->CmdHlp.pfnPrintf(&pDbgc->CmdHlp, NULL, " args[%u]=%#llx", i, pEvent->u.Generic.auArgs[i]);
+                            if (RT_SUCCESS(rc))
+                                rc = pDbgc->CmdHlp.pfnPrintf(&pDbgc->CmdHlp, NULL, "\n");
+                        }
                     }
                 }
@@ -2851 +2855 @@
 
         if (!DBGFR3IsHalted(pThis->Dbgc.pUVM, VMCPUID_ALL))
+        {
             rc = DBGFR3Halt(pThis->Dbgc.pUVM, VMCPUID_ALL);
+            if (RT_FAILURE(rc))
+                LogRel(("DBGC/Gdb: Failed to halt VM (%Rrc), debugger might behave unexpectedly\n"));
+        }
 
         /*