Changeset 104623 in vbox

Timestamp:

May 14, 2024 11:41:26 AM (12 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

163167

Message:

ValidationKit/TXS: Fixed warnings + shutdown waiting check. bugref:3409

File:

• trunk/src/VBox/ValidationKit/utils/TestExecServ/TestExecService.cpp (modified) (4 diffs)

trunk/src/VBox/ValidationKit/utils/TestExecServ/TestExecService.cpp

@@ -1647 +1647 @@
      * reconnecting and seeing that our UUID was unchanged.
      */
-    int rc;
     if (pPktHdr->cb != sizeof(TXSPKTHDR))
         return txsReplyBadSize(pPktHdr, sizeof(TXSPKTHDR));
     g_pTransport->pfnNotifyReboot();
-    rc = txsReplyAck(pPktHdr);
+    int rc = txsReplyAck(pPktHdr);
+    AssertRCReturn(rc, rc);
     RTThreadSleep(2560);                /* fudge factor */
     g_pTransport->pfnTerm();
@@ -2376 +2376 @@
     {
         rc2 = RTThreadWait(pTxsExec->hThreadWaiter, RT_MS_1SEC / 2, NULL);
-        if (RT_SUCCESS(rc))
+        if (RT_SUCCESS(rc2))
         {
             pTxsExec->hThreadWaiter = NIL_RTTHREAD;
@@ -3653 +3653 @@
     bool        fAutoUpgrade    = true;
     bool        fDaemonize      = true;
-    bool        fDaemonized     = false;
     const char *pszUpgrading    = NULL;
 #ifdef RT_OS_SOLARIS
@@ -3784 +3783 @@
 
             case 'Z':
-                fDaemonized = true;
                 fDaemonize = false;
                 break;