Changeset 104693 in vbox for trunk/src/VBox/Devices

Timestamp:

May 16, 2024 4:44:11 PM (9 months ago)

Author:

vboxsync

Message:

Devices + GuestHost: Fixed warnings. ​​bugref:3409

Location:

trunk/src/VBox/Devices/Audio

Files:

• AudioTestServiceTcp.cpp (modified) (1 diff)
• DevHdaStream.cpp (modified) (1 diff)
• DrvAudio.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/AudioTestServiceTcp.cpp

@@ -464 +464 @@
     else
     {
-        if (pClient)
-        {
-            atsTcpFreeClient(pThis, pClient);
-            pClient = NULL;
-        }
+        atsTcpFreeClient(pThis, pClient);
+        pClient = NULL;
     }
 

trunk/src/VBox/Devices/Audio/DevHdaStream.cpp

@@ -1080 +1080 @@
         Assert(AudioHlpPcmPropsAreValidAndSupported(&pStreamShared->State.Cfg.Props));
 
-        if (fEnable)
-        {
-            if (!AudioHlpFileIsOpen(pStreamR3->Dbg.Runtime.pFileStream))
-            {
-                int rc2 = AudioHlpFileOpen(pStreamR3->Dbg.Runtime.pFileStream, AUDIOHLPFILE_DEFAULT_OPEN_FLAGS,
-                                           &pStreamShared->State.Cfg.Props);
-                AssertRC(rc2);
-            }
-
-            if (!AudioHlpFileIsOpen(pStreamR3->Dbg.Runtime.pFileDMARaw))
-            {
-                int rc2 = AudioHlpFileOpen(pStreamR3->Dbg.Runtime.pFileDMARaw, AUDIOHLPFILE_DEFAULT_OPEN_FLAGS,
-                                           &pStreamShared->State.Cfg.Props);
-                AssertRC(rc2);
-            }
-
-            if (!AudioHlpFileIsOpen(pStreamR3->Dbg.Runtime.pFileDMAMapped))
-            {
-                int rc2 = AudioHlpFileOpen(pStreamR3->Dbg.Runtime.pFileDMAMapped, AUDIOHLPFILE_DEFAULT_OPEN_FLAGS,
-                                           &pStreamShared->State.Cfg.Props);
-                AssertRC(rc2);
-            }
+        if (!AudioHlpFileIsOpen(pStreamR3->Dbg.Runtime.pFileStream))
+        {
+            int rc2 = AudioHlpFileOpen(pStreamR3->Dbg.Runtime.pFileStream, AUDIOHLPFILE_DEFAULT_OPEN_FLAGS,
+                                       &pStreamShared->State.Cfg.Props);
+            AssertRC(rc2);
+        }
+
+        if (!AudioHlpFileIsOpen(pStreamR3->Dbg.Runtime.pFileDMARaw))
+        {
+            int rc2 = AudioHlpFileOpen(pStreamR3->Dbg.Runtime.pFileDMARaw, AUDIOHLPFILE_DEFAULT_OPEN_FLAGS,
+                                       &pStreamShared->State.Cfg.Props);
+            AssertRC(rc2);
+        }
+
+        if (!AudioHlpFileIsOpen(pStreamR3->Dbg.Runtime.pFileDMAMapped))
+        {
+            int rc2 = AudioHlpFileOpen(pStreamR3->Dbg.Runtime.pFileDMAMapped, AUDIOHLPFILE_DEFAULT_OPEN_FLAGS,
+                                       &pStreamShared->State.Cfg.Props);
+            AssertRC(rc2);
         }
     }

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -1623 +1623 @@
         }
     }
-    else if (CfgReq.Backend.cFramesPreBuffering == 0) /* Was the pre-buffering requested as being disabeld? Tell the users. */
+    else /* Was the pre-buffering requested as being disabeld? Tell the users. */
     {
         LogRel2(("Audio: Pre-buffering is disabled for stream '%s'\n", pCfgAcq->szName));