Changeset 104713 in vbox for trunk/src/VBox/Main/src-client

Timestamp:

May 17, 2024 2:45:27 PM (8 months ago)

Author:

vboxsync

Message:

Recording/Main: Do not alter the settings (the global recording enabled/disabled bit) when Console::i_recordingStop() is being called. This led the VM to have disabled recording on the next run even if recording actually was intended to stay enabled (via settings).

File:

• trunk/src/VBox/Main/src-client/ConsoleImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-client/ConsoleImpl.cpp

@@ -7654 +7654 @@
 /**
  * Stops recording. Does nothing if recording is not active.
- */
-int Console::i_recordingStop(util::AutoWriteLock *pAutoLock /* = NULL */)
+ *
+ * Note: This does *not* disable recording for a VM, in other words,
+ *       it does not change the VM's recording (enabled) setting.
+ */
+int Console::i_recordingStop(util::AutoWriteLock *)
 {
     if (!mRecording.mCtx.IsStarted())
@@ -7668 +7671 @@
         for (unsigned uScreen = 0; uScreen < cStreams; ++uScreen)
             mDisplay->i_recordingScreenChanged(uScreen);
-
-        if (pAutoLock)
-            pAutoLock->release();
-
-        ComPtr<IRecordingSettings> pRecordSettings;
-        HRESULT hrc = mMachine->COMGETTER(RecordingSettings)(pRecordSettings.asOutParam());
-        ComAssertComRC(hrc);
-        hrc = pRecordSettings->COMSETTER(Enabled)(FALSE);
-        ComAssertComRC(hrc);
-
-        if (pAutoLock)
-            pAutoLock->acquire();
     }